This repository was archived by the owner on Feb 25, 2025. It is now read-only.
et generates {out}/{buildName} if missing on et {build|test|query}
#52866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
May 16, 2024
| if (useLto) '--lto' else '--no-lto', | ||
| ]; | ||
|
|
||
| if (!await ensureBuildDir(environment, build, enableRbe: useRbe)) { |
There was a problem hiding this comment.
This is only needed if argResults.rest is non-empty since the first thing that runBuild is going to do is run gn.
There was a problem hiding this comment.
Good catch, done!
| /// Given a [Build] object, run only its GN step. | ||
| Future<int> runGn( | ||
| /// Run a [build]'s GN step if the output directory is missing. | ||
| Future<bool> ensureBuildDir( |
There was a problem hiding this comment.
I'd suggest keeping runGn and maybe making it lib private (_runGn), and then implementing ensureBuildDir() as a public wrapper around it.
Comment on lines
227
to
237
| if (built) { | ||
| if (!buildDir.existsSync()) { | ||
| environment.logger.error( | ||
| 'The specified build did not produce the expected output directory: ' | ||
| '${buildDir.path}', | ||
| ); | ||
| return false; | ||
| } | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Small simplification.
Suggested change
| if (built) { | |
| if (!buildDir.existsSync()) { | |
| environment.logger.error( | |
| 'The specified build did not produce the expected output directory: ' | |
| '${buildDir.path}', | |
| ); | |
| return false; | |
| } | |
| return true; | |
| } | |
| return false; | |
| if (built && !buildDir.existsSync()) { | |
| environment.logger.error( | |
| 'The specified build did not produce the expected output directory: ' | |
| '${buildDir.path}', | |
| ); | |
| return false; | |
| } | |
| return built; |
There was a problem hiding this comment.
Yeah that's much better, done.
matanlurey
commented
May 16, 2024
| /// Given a [Build] object, run only its GN step. | ||
| Future<int> runGn( | ||
| /// Run a [build]'s GN step if the output directory is missing. | ||
| Future<bool> ensureBuildDir( |
Comment on lines
227
to
237
| if (built) { | ||
| if (!buildDir.existsSync()) { | ||
| environment.logger.error( | ||
| 'The specified build did not produce the expected output directory: ' | ||
| '${buildDir.path}', | ||
| ); | ||
| return false; | ||
| } | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Yeah that's much better, done.
| if (useLto) '--lto' else '--no-lto', | ||
| ]; | ||
|
|
||
| if (!await ensureBuildDir(environment, build, enableRbe: useRbe)) { |
There was a problem hiding this comment.
Good catch, done!
zanderso
approved these changes
May 16, 2024
matanlurey
added
autosubmit
|
Actually after @zanderso's feedback I can revert all of the test changes, thanks again! |
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 16, 2024
…148455) flutter/engine@942d7c3...9e17588 2024-05-16 [email protected] `et` generates `{out}/{buildName}` if missing on `et {build|test|query}` (flutter/engine#52866) 2024-05-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Revamp the engine style guide, remove `always_specify_types`. (#52859)" (flutter/engine#52867) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#148442.
This restores functionality that existed prior in #52832:
runGntoensureBuildDir, which is in practice what it does.