[Embedder API] Add helper to create viewport metrics #51562
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
| return LOG_EMBEDDER_ERROR( | ||
| kInvalidArguments, | ||
| "Physical view insets are invalid. They must be non-negative."); | ||
| std::variant<flutter::ViewportMetrics, std::string> metrics_or_error = |
There was a problem hiding this comment.
Instead of std::variant shall we use std::pair? This pattern is also used in other functions such as InferExternalViewEmbedderFromArgs.
There was a problem hiding this comment.
I slightly prefer std::variant here since we're returning a struct instead of a pointer. I don't feel strongly though, I can switch to a std::pair if folks prefer
There was a problem hiding this comment.
On a second thought, std::variant is better, because only one of them is possible.
loic-sharma
added
the
autosubmit
…145611) flutter/engine@09dadce...63ff0de 2024-03-22 [email protected] [Embedder API] Add helper to create viewport metrics (flutter/engine#51562) 2024-03-22 [email protected] [Windows] Allow view controllers to not own the engine (flutter/engine#51570) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This is a refactoring with no semantic changes.
In a subsequent change, an
FlutterEngineAddViewembedder API will be introduced to add views. This API will need to create the view's initial engine viewport metrics, so this splits out the logic fromFlutterEngineSendWindowMetricsEventinto a helper.Follow-up change that uses this new helper: #51523
Design doc: https://flutter.dev/go/multi-view-embedder-apis
Prepares for: flutter/flutter#144806
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.