This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Embedder API] Add view #51523
Merged
[Embedder API] Add view #51523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
Mar 19, 2024
8 tasks
loic-sharma
commented
Mar 20, 2024
loic-sharma
commented
Mar 20, 2024
dkwingsmt
reviewed
Mar 20, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
_This is a refactoring with no semantic changes._ In a subsequent change, an `FlutterEngineAddView` embedder API will be introduced to add views. This API will need to create the view's initial engine viewport metrics, so this splits out the logic from `FlutterEngineSendWindowMetricsEvent` into a helper. Follow-up change that uses this new helper: #51523 Design doc: https://flutter.dev/go/multi-view-embedder-apis Prepares for: flutter/flutter#144806 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
loic-sharma
force-pushed
the
embedder_api_add_view
branch
from
81c5d1b to
8ab4949
Compare
dkwingsmt
reviewed
Mar 25, 2024
Contributor
|
Ooops sorry I forgot to submit my reviews. Here they are. Feel free to change them in the official PRs. |
8 tasks
loic-sharma
force-pushed
the
embedder_api_add_view
branch
from
49f9d48 to
5069ec8
Compare
dkwingsmt
approved these changes
Mar 29, 2024
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM, nice catch with the callbacks that are incompatible with multiple views. (Make sure to get approval from Chris or Chinmay)
cbracken
reviewed
Apr 2, 2024
cbracken
reviewed
Apr 2, 2024
cbracken
reviewed
Apr 2, 2024
| FlutterEngineDisplayId display_id; | ||
| /// The view that this event is describing. | ||
| int64_t view_id; | ||
| } FlutterWindowMetricsEvent; |
Member
There was a problem hiding this comment.
Note to future archaeologists - this is just code moving around; there are no diffs here.
cbracken
reviewed
Apr 2, 2024
cbracken
reviewed
Apr 2, 2024
| info.view_id = 123; | ||
| info.view_metrics = &metrics; | ||
| info.add_view_callback = [](const FlutterAddViewResult* result) { | ||
| ASSERT_TRUE(result->added); |
Member
There was a problem hiding this comment.
nit: Here and in a few places below -- given that this is just checking a result (rather than necessary for further checks below) should this be EXPECT_TRUE rather than ASSERT_TRUE? Agreed the two others should be asserts in this case.
Member
Author
There was a problem hiding this comment.
Ah good point. I did a pass through the tests and "downgraded" assertions that could be expectations.
cbracken
approved these changes
Apr 2, 2024
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
lgtm with just a few small nits.
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 2, 2024
…146159) flutter/engine@c60b00a...5dbcfdc 2024-04-02 [email protected] Do not use `adb shell screenrecord` during CI runs. (flutter/engine#51848) 2024-04-02 [email protected] [Embedder API] Add view (flutter/engine#51523) 2024-04-02 [email protected] [skwasm] Fix `Paragraph.getLineBoundary` (flutter/engine#51846) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
FlutterEngineAddViewto the embedder API. This will be used to add a view.Design doc: https://flutter.dev/go/multi-view-embedder-apis
Part of flutter/flutter#144806
Part of flutter/flutter#142845
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.