This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Avoid unnecessary transform resets for pixel snapping #51337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Discovered while working on #50935 |
| bool RasterCacheUtil::ComputeIntegralTransCTM(const SkM44& in, SkM44* out) { | ||
| // Avoid integral snapping if the matrix has complex transformation to avoid | ||
| // the artifact observed in https://github.com/flutter/flutter/issues/41654. | ||
| if (in.rc(0, 1) != 0 || in.rc(0, 2) != 0) { |
Contributor
There was a problem hiding this comment.
rc = row column? Its quite the API...
Contributor
There was a problem hiding this comment.
(I realize this is from Skia)
| return false; | ||
| } | ||
|
|
||
| bool RasterCacheUtil::ComputeIntegralTransCTM(const SkM44& in, SkM44* out) { |
Contributor
There was a problem hiding this comment.
Do we have any tests that are exercising the SkM44 code path?
jonahwilliams
approved these changes
Mar 13, 2024
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
Overall LGTM but I'd like it if there was an SkM44 test that we needed to update too...
Contributor
Author
|
There were added to fix problems we had with not maintaining full 4x4 transforms during the layer recursion so they are tested someplace indirectly. But, I could add some LSS/DlMCT tests to test them more directly. |
knopp
approved these changes
Mar 13, 2024
flar
force-pushed
the
avoid-unnecessary-integral-translation-operations
branch
from
cce3017 to
d5d1dab
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 14, 2024
…145176) flutter/engine@cc1e7d1...7b49dc9 2024-03-14 [email protected] Roll Dart SDK from 749988e4d748 to 2bc8b222d01f (1 revision) (flutter/engine#51421) 2024-03-14 [email protected] [web] - fix text editing IME composition interruption on geometry updates (flutter/engine#51323) 2024-03-14 [email protected] Avoid unnecessary transform resets for pixel snapping (flutter/engine#51337) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During some new development work that might make transform resets more expensive we realized that the resets were mostly coming from the calls to snap the transform to a pixel translate value and many of those were NOPs since the transform was already on a pixel translate value. This PR will avoid those trivially unnecessary reset operations.