This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] - fix text editing IME composition interruption on geometry updates #51323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Mar 11, 2024
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
Thanks for figuring out this long standing issue!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 14, 2024
…145176) flutter/engine@cc1e7d1...7b49dc9 2024-03-14 [email protected] Roll Dart SDK from 749988e4d748 to 2bc8b222d01f (1 revision) (flutter/engine#51421) 2024-03-14 [email protected] [web] - fix text editing IME composition interruption on geometry updates (flutter/engine#51323) 2024-03-14 [email protected] Avoid unnecessary transform resets for pixel snapping (flutter/engine#51337) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where IME composition gets interrupted when the
setEditableSizeAndTransformplatform message is received mid-composition. This occurs when a multiline input expands and needs to inform the underlyingtextareato update its size.Fixes flutter/flutter#134797
Fixes flutter/flutter#98817
Pre-launch Checklist
///).