Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] use DefaultUniformAlignment for compute buffers. #51336

Closed
wants to merge 2 commits into from
Closed

[Impeller] use DefaultUniformAlignment for compute buffers. #51336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a4f8e0
[Impeller] use DefaultUniformAlignment for compute buffers.
Mar 11, 2024
9f66666
turn on validation.
Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions impeller/entity/geometry/point_field_geometry.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ GeometryResult PointFieldGeometry::GetPositionBufferGPU(
host_buffer.Emplace(points_.data(), points_.size() * sizeof(Point),
DefaultUniformAlignment());

BufferView geometry_buffer =
host_buffer.Emplace(nullptr, total * sizeof(Point), alignof(Point));
BufferView geometry_buffer = host_buffer.Emplace(
nullptr, total * sizeof(Point), DefaultUniformAlignment());
Copy link
Member

@chinmaygarde chinmaygarde Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the max of the alignof the Point and the default uniform alignment right?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #51341


BufferView output;
{
Expand Down Expand Up @@ -185,8 +185,8 @@ GeometryResult PointFieldGeometry::GetPositionBufferGPU(
}

if (texture_coverage.has_value() && effect_transform.has_value()) {
BufferView geometry_uv_buffer =
host_buffer.Emplace(nullptr, total * sizeof(Vector4), alignof(Vector4));
BufferView geometry_uv_buffer = host_buffer.Emplace(
nullptr, total * sizeof(Vector4), DefaultUniformAlignment());
Copy link
Member

@chinmaygarde chinmaygarde Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto about the max.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #51341


using UV = UvComputeShader;

Expand Down
1 change: 1 addition & 0 deletions impeller/playground/playground_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ std::unique_ptr<PlaygroundImpl> PlaygroundImpl::Create(
#endif // IMPELLER_ENABLE_OPENGLES
#if IMPELLER_ENABLE_VULKAN
case PlaygroundBackend::kVulkan:
switches.enable_vulkan_validation = true;
return std::make_unique<PlaygroundImplVK>(switches);
#endif // IMPELLER_ENABLE_VULKAN
default:
Expand Down