[Impeller] use DefaultUniformAlignment for compute buffers. #51336
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| BufferView geometry_buffer = | ||
| host_buffer.Emplace(nullptr, total * sizeof(Point), alignof(Point)); | ||
| BufferView geometry_buffer = host_buffer.Emplace( | ||
| nullptr, total * sizeof(Point), DefaultUniformAlignment()); |
There was a problem hiding this comment.
This should be the max of the alignof the Point and the default uniform alignment right?
|
Turning on validation to see which ones fail, then I'll add a deny list like goldens has. |
| BufferView geometry_uv_buffer = | ||
| host_buffer.Emplace(nullptr, total * sizeof(Vector4), alignof(Vector4)); | ||
| BufferView geometry_uv_buffer = host_buffer.Emplace( | ||
| nullptr, total * sizeof(Vector4), DefaultUniformAlignment()); |
|
Done in #51341 |
2 participants
Fixes flutter/flutter#144959
locally this only shows failures before on the impeller_goldens test shard.