This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "[Impeller] fold memory check into allocator_vk (#51187)" #51243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5bbac1a.
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Mar 6, 2024
auto-submit
bot
deleted the
revert_5bbac1a5c5762e93c130c08123e0e856efc73996
branch
Contributor
|
Live by the sword die by the sword, I should have followed @matanlurey's advice on one change at a time. |
Contributor
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 7, 2024
…144741) flutter/engine@53ddbdf...4f6ea31 2024-03-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] fold memory check into allocator_vk (#51187)" (flutter/engine#51243) 2024-03-06 [email protected] Manual roll Dart SDK from 50464546d92d to 9ea8813ab4d4 (5 revisions) (flutter/engine#51239) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #51187
Initiated by: jonahwilliams
Reason for reverting: unexpected benchmark regression
https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller__transition_perf&selected=commit%3D396
Original PR Author: jonahwilliams
Reviewed By: {matanlurey}
This change reverts the following previous change:
Various cleanups to Vulkan allocator implementation:
Part of flutter/flutter#144617