Reverts "[Impeller] fold memory check into allocator_vk (#51187)" (#51243)

Reverts: #51187
Initiated by: jonahwilliams
Reason for reverting: unexpected benchmark regression

https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller__transition_perf&selected=commit%3D396
Original PR Author: jonahwilliams

Reviewed By: {matanlurey}

This change reverts the following previous change:
Various cleanups to Vulkan allocator implementation:

1. Fixes flutter/flutter#137454
2. Fold device transient cap check into allocator.
3. adds debug tracking for total memory usage in MB (a followup change needs to be made to driver to plumb it through)
4. Small cleanups to mock vulkan so an allocator can be created from it.
5. depth/stencil shouldn't be input attachments.

Part of flutter/flutter#144617

Author: auto-submit[bot]

ci/licenses_golden/excluded_files

@@ -168,7 +168,6 @@
 ../../../flutter/impeller/playground
 ../../../flutter/impeller/renderer/backend/gles/test
 ../../../flutter/impeller/renderer/backend/metal/texture_mtl_unittests.mm
-../../../flutter/impeller/renderer/backend/vulkan/allocator_vk_unittests.cc
 ../../../flutter/impeller/renderer/backend/vulkan/blit_command_vk_unittests.cc
 ../../../flutter/impeller/renderer/backend/vulkan/command_encoder_vk_unittests.cc
 ../../../flutter/impeller/renderer/backend/vulkan/command_pool_vk_unittests.cc

impeller/core/allocator.h

@@ -44,12 +44,6 @@ class Allocator {
 
   virtual ISize GetMaxTextureSizeSupported() const = 0;
 
-  /// @brief Write debug memory usage information to the dart timeline in debug
-  ///        and profile modes.
-  ///
-  ///        This is only supported on the Vulkan backend.
-  virtual void DebugTraceMemoryStatistics() const {};
-
  protected:
   Allocator();
 

impeller/renderer/backend/gles/capabilities_gles.cc

@@ -181,6 +181,10 @@ bool CapabilitiesGLES::SupportsDecalSamplerAddressMode() const {
   return supports_decal_sampler_address_mode_;
 }
 
+bool CapabilitiesGLES::SupportsDeviceTransientTextures() const {
+  return false;
+}
+
 PixelFormat CapabilitiesGLES::GetDefaultColorFormat() const {
   return PixelFormat::kR8G8B8A8UNormInt;
 }

impeller/renderer/backend/gles/capabilities_gles.h

@@ -107,6 +107,9 @@ class CapabilitiesGLES final
   // |Capabilities|
   bool SupportsDecalSamplerAddressMode() const override;
 
+  // |Capabilities|
+  bool SupportsDeviceTransientTextures() const override;
+
   // |Capabilities|
   PixelFormat GetDefaultColorFormat() const override;
 

impeller/renderer/backend/gles/test/capabilities_unittests.cc

@@ -24,6 +24,7 @@ TEST(CapabilitiesGLES, CanInitializeWithDefaults) {
   EXPECT_FALSE(capabilities->SupportsComputeSubgroups());
   EXPECT_FALSE(capabilities->SupportsReadFromResolve());
   EXPECT_FALSE(capabilities->SupportsDecalSamplerAddressMode());
+  EXPECT_FALSE(capabilities->SupportsDeviceTransientTextures());
 
   EXPECT_EQ(capabilities->GetDefaultColorFormat(),
             PixelFormat::kR8G8B8A8UNormInt);

impeller/renderer/backend/metal/context_mtl.mm

@@ -66,6 +66,7 @@ static bool DeviceSupportsComputeSubgroups(id<MTLDevice> device) {
       .SetSupportsCompute(true)
       .SetSupportsComputeSubgroups(DeviceSupportsComputeSubgroups(device))
       .SetSupportsReadFromResolve(true)
+      .SetSupportsDeviceTransientTextures(true)
       .SetDefaultGlyphAtlasFormat(PixelFormat::kA8UNormInt)
       .Build();
 }

impeller/renderer/backend/vulkan/BUILD.gn

@@ -8,7 +8,6 @@ import("../../../tools/impeller.gni")
 impeller_component("vulkan_unittests") {
   testonly = true
   sources = [
-    "allocator_vk_unittests.cc",
     "blit_command_vk_unittests.cc",
     "command_encoder_vk_unittests.cc",
     "command_pool_vk_unittests.cc",