Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Delete and create iOS simulator before running Scenario app test #50835

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Delete and create iOS simulator before running Scenario app test #50835

merged 1 commit into from
Feb 22, 2024

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Feb 21, 2024 •
edited
Loading

Make iOS Scenario app tests create the simulator it needs before the tests. Also, delete any existing matching simulators to prevent duplicates.

Fixes flutter/flutter#143870.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth marked this pull request as ready for review February 21, 2024 21:06
@keyonghan keyonghan mentioned this pull request Feb 21, 2024
Closed
zanderso
zanderso reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DBC: Not for this PR. My sense is that the logic in this script is outgrowing what we'd normally like to maintain in a bash script. We should consider porting this to Python, or ideally Dart if possible.

@vashworth
Copy link
Contributor Author

vashworth commented Feb 22, 2024

@zanderso What does DBC mean?

@zanderso
Copy link
Member

zanderso commented Feb 22, 2024

@zanderso What does DBC mean?

Drive-by comment.

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2024
@vashworth vashworth mentioned this pull request Feb 22, 2024
Closed
@vashworth
Copy link
Contributor Author

vashworth commented Feb 22, 2024

My sense is that the logic in this script is outgrowing what we'd normally like to maintain in a bash script. We should consider porting this to Python, or ideally Dart if possible.

I filed a new issue: flutter/flutter#143953

hellohuanlin
hellohuanlin approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it incur additional time (how much) when running on CI

@vashworth
Copy link
Contributor Author

vashworth commented Feb 22, 2024

Does it incur additional time (how much) when running on CI

We do something similar in packages and it takes ~3.9 seconds
Example: See step 12.15 (which attempts to delete and then creates simulator):
https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64%20custom_package_tests%20master/10823/overview

@auto-submit auto-submit bot merged commit 547c834 into flutter:main Feb 22, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2024
@engine-flutter-autoroll
547c83466 Delete and create iOS simulator before running Scenario app…
6e16fd2 
… test (flutter/engine#50835)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2024
@engine-flutter-autoroll
547c83466 Delete and create iOS simulator before running Scenario app…
e651cdf 
… test (flutter/engine#50835)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 22, 2024
@engine-flutter-autoroll
Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (#…
0387f62 
…143972)

flutter/engine@06448ee...cb6115d

2024-02-22 [email protected] Avoid generated plugin registrant warnings for scenario_app (flutter/engine#50874)
2024-02-22 [email protected] Delete and create iOS simulator before running Scenario app test (flutter/engine#50835)
2024-02-22 [email protected] Roll Skia from b9c16065b76d to dd8cd405d145 (2 revisions) (flutter/engine#50872)
2024-02-22 [email protected] Remove 'bringup: true' from 'Mac mac_unopt' (flutter/engine#50865)
2024-02-22 [email protected] Pass the missing strut half leading flag over to skia paragraph builder (flutter/engine#50385)
2024-02-22 [email protected] Implement frame timing callbacks in Skwasm. (flutter/engine#50737)
2024-02-22 [email protected] [Impeller] Add stroke benchmarks that create UVs with no transform (flutter/engine#50847)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove WindowManager reflection in SingleViewPresentation.java (#49996)" (flutter/engine#50873)
2024-02-22 [email protected] Use RBE on more Windows builders (flutter/engine#50866)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] cache onscreen render targets. (#50751)" (flutter/engine#50871)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
547c83466 Delete and create iOS simulator before running Scenario app…
dfd38db 
… test (flutter/engine#50835)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 23, 2024
@engine-flutter-autoroll
Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revi…
ce100cd 
…sions) (#143989)

Manual roll requested by [email protected]

flutter/engine@06448ee...0f3ad23

2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implement frame timing callbacks in Skwasm. (#50737)" (flutter/engine#50895)
2024-02-22 [email protected] Roll Dart SDK from 0f0f7400c38a to e2f2d9b464e9 (4 revisions) (flutter/engine#50881)
2024-02-22 [email protected] Roll Skia from a285cd79614c to 58772db6bc46 (3 revisions) (flutter/engine#50884)
2024-02-22 [email protected] [Impeller] moved the kernel size assert to a more appropriate location. (flutter/engine#50880)
2024-02-22 [email protected] Build macOS engine as an xcframework (flutter/engine#50300)
2024-02-22 [email protected] Roll Skia from dd8cd405d145 to a285cd79614c (3 revisions) (flutter/engine#50878)
2024-02-22 [email protected] Avoid generated plugin registrant warnings for scenario_app (flutter/engine#50874)
2024-02-22 [email protected] Delete and create iOS simulator before running Scenario app test (flutter/engine#50835)
2024-02-22 [email protected] Roll Skia from b9c16065b76d to dd8cd405d145 (2 revisions) (flutter/engine#50872)
2024-02-22 [email protected] Remove 'bringup: true' from 'Mac mac_unopt' (flutter/engine#50865)
2024-02-22 [email protected] Pass the missing strut half leading flag over to skia paragraph builder (flutter/engine#50385)
2024-02-22 [email protected] Implement frame timing callbacks in Skwasm. (flutter/engine#50737)
2024-02-22 [email protected] [Impeller] Add stroke benchmarks that create UVs with no transform (flutter/engine#50847)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove WindowManager reflection in SingleViewPresentation.java (#49996)" (flutter/engine#50873)
2024-02-22 [email protected] Use RBE on more Windows builders (flutter/engine#50866)
2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] cache onscreen render targets. (#50751)" (flutter/engine#50871)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@zanderso zanderso zanderso approved these changes

@hellohuanlin hellohuanlin hellohuanlin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linux_mac_unopt build has a recent history of a number of infra failures

3 participants

@vashworth @zanderso @hellohuanlin