Build macOS engine as an xcframework #50300
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
It's not ideal, but you could add tests in the framework, ready to merge right after the commit rolls into the framework and you are pretty confident it won't be reverted (probably not worth a manual roll). Note that the framework codesigning tests run on beta and stable will fail until you add https://github.com/flutter/flutter/blob/83aca58fa7cdc4b8ba019cbad863afbef11c6c05/dev/bots/test.dart#L1729 |
+1, let's make sure we have the tool change as ready as possible so the artifact size isn't doubled on the next stable. |
|
Corresponding framework PR: flutter/flutter#143244 |
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR should not affect
And the tool only downloads artifacts specifically specified to be downloaded. For example: https://github.com/flutter/flutter/blob/c530276f7806c77da2541c518a0e103c9bb44f10/packages/flutter_tools/lib/src/flutter_cache.dart#L860-L869 From what I can tell, uploading this new zip file shouldn't affect anything. |
vashworth
added
the
autosubmit
…143980) flutter/engine@cb6115d...c5d2e01 2024-02-22 [email protected] [Impeller] moved the kernel size assert to a more appropriate location. (flutter/engine#50880) 2024-02-22 [email protected] Build macOS engine as an xcframework (flutter/engine#50300) 2024-02-22 [email protected] Roll Skia from dd8cd405d145 to a285cd79614c (3 revisions) (flutter/engine#50878) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…sions) (#143989) Manual roll requested by [email protected] flutter/engine@06448ee...0f3ad23 2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implement frame timing callbacks in Skwasm. (#50737)" (flutter/engine#50895) 2024-02-22 [email protected] Roll Dart SDK from 0f0f7400c38a to e2f2d9b464e9 (4 revisions) (flutter/engine#50881) 2024-02-22 [email protected] Roll Skia from a285cd79614c to 58772db6bc46 (3 revisions) (flutter/engine#50884) 2024-02-22 [email protected] [Impeller] moved the kernel size assert to a more appropriate location. (flutter/engine#50880) 2024-02-22 [email protected] Build macOS engine as an xcframework (flutter/engine#50300) 2024-02-22 [email protected] Roll Skia from dd8cd405d145 to a285cd79614c (3 revisions) (flutter/engine#50878) 2024-02-22 [email protected] Avoid generated plugin registrant warnings for scenario_app (flutter/engine#50874) 2024-02-22 [email protected] Delete and create iOS simulator before running Scenario app test (flutter/engine#50835) 2024-02-22 [email protected] Roll Skia from b9c16065b76d to dd8cd405d145 (2 revisions) (flutter/engine#50872) 2024-02-22 [email protected] Remove 'bringup: true' from 'Mac mac_unopt' (flutter/engine#50865) 2024-02-22 [email protected] Pass the missing strut half leading flag over to skia paragraph builder (flutter/engine#50385) 2024-02-22 [email protected] Implement frame timing callbacks in Skwasm. (flutter/engine#50737) 2024-02-22 [email protected] [Impeller] Add stroke benchmarks that create UVs with no transform (flutter/engine#50847) 2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove WindowManager reflection in SingleViewPresentation.java (#49996)" (flutter/engine#50873) 2024-02-22 [email protected] Use RBE on more Windows builders (flutter/engine#50866) 2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] cache onscreen render targets. (#50751)" (flutter/engine#50871) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Creates and adds FlutterMacOS.xcframework to out/mac or out/host.
Creates and archives FlutterMacOS.xcframework when building mac_host_engine. Archives the xcframework in a new zipped folder at
darwin-x64/framework.zip,darwin-x64-profile/framework.zip,darwin-x64-release/framework.zip.The FlutterMacOS.framework is also still archived currently - I thought it'd be better to keep it archived so we don't have to worry about the tool breaking until we're ready to remove it.
Part of flutter/flutter#126016.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.