Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Feb 2, 2024

@zanderso zanderso added warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels Feb 2, 2024
@CaseyHillers
Copy link
Contributor

\cc @zijiehe-google-com FYI

Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This SGTM. This may cause an issue on the release branches or 1P CPs, but I can do local reverts there until this is fixed.

- os=Linux
dimensions:
kvm: "1"
bringup: true
Copy link
Contributor

@keyonghan keyonghan Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, we need to increase the timeout if #50058 is intended. Otherwise this will just keep flaking in staging due to timeout.

@auto-submit auto-submit bot merged commit acb6fbc into main Feb 2, 2024
@auto-submit auto-submit bot deleted the zanderso-patch-5 branch February 2, 2024 18:23
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2024
@zanderso zanderso added the revert Label used to revert changes in a closed and merged pull request. label Feb 2, 2024
auto-submit bot pushed a commit that referenced this pull request Feb 2, 2024
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Feb 2, 2024
auto-submit bot added a commit that referenced this pull request Feb 2, 2024
Reverts #50288
Initiated by: zanderso
This change reverts the following previous change:
Original Description:
For flutter/flutter#142811
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 2, 2024
…142832)

flutter/engine@e292632...266d5d0

2024-02-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Move linux_fuchsia to staging" (flutter/engine#50294)
2024-02-02 [email protected] Revert "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds" (flutter/engine#50291)
2024-02-02 [email protected] Move linux_fuchsia to staging (flutter/engine#50288)
2024-02-02 [email protected] Add the focus state related methods to the platform dispatcher (flutter/engine#50273)
2024-02-02 [email protected] Add a link the different possible Android virtual device configs (flutter/engine#50267)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants