This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add the focus state related methods to the platform dispatcher #50273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zanderso |
goderbauer
approved these changes
Feb 2, 2024
lib/ui/platform_dispatcher.dart
Outdated
| /// the callback receives the following [ViewFocusEvent]: | ||
| /// | ||
| /// ```dart | ||
| /// ViewFocusEvent( |
There was a problem hiding this comment.
For analyzing the snippets, dart:ui is imported as import 'dart:ui' as ui. So, you need to prefix everything coming from dart:ui with ui. in these samples.
There was a problem hiding this comment.
Thanks for the quick review Michael. Will for sure send a follow up PR to bring back those snippets.
Interesting, these patterns are somewhat hidden. It is not intuitive what's expected.
Also, why don't we make these verifications as part of the engine submit process?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 2, 2024
…142832) flutter/engine@e292632...266d5d0 2024-02-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Move linux_fuchsia to staging" (flutter/engine#50294) 2024-02-02 [email protected] Revert "[Fuchsia] Execute most of the testing/fuchsia/test_suites.yaml on debug and release builds" (flutter/engine#50291) 2024-02-02 [email protected] Move linux_fuchsia to staging (flutter/engine#50288) 2024-02-02 [email protected] Add the focus state related methods to the platform dispatcher (flutter/engine#50273) 2024-02-02 [email protected] Add a link the different possible Android virtual device configs (flutter/engine#50267) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were originally landed on #49841 but reverted in 0eb7b10. I fixed the offending dart snippets and (think) they now will work without issues (I think I was able to verify them locally by manually patching my bin/cache/... copy of these files with these changes).
Relevant Issues are:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.