Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gaaclarke
Copy link
Member

followup from #50146

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 31, 2024

auto label is removed for flutter/engine/50218, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2024
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2024
@auto-submit auto-submit bot merged commit bc78e2c into flutter:main Feb 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 2, 2024
…142783)

flutter/engine@dd4c79a...b35153d

2024-02-02 [email protected] Manual roll Dart SDK from 82936dcdaf4f to 5a5d4c262200 (2 revisions) (flutter/engine#50264)
2024-02-01 [email protected] Remove number of arguments from defining Dart FFI (flutter/engine#50153)
2024-02-01 [email protected] Refactor the linux_android targets to make use of recent changes to android virtual device params (flutter/engine#50099)
2024-02-01 [email protected] Re-add tests deleted on accident (flutter/engine#50223)
2024-02-01 [email protected] [Impeller] updated todos from opengles golden work (flutter/engine#50218)
2024-02-01 [email protected] Get bounds from RTree in DLBuilder::Build() (flutter/engine#50253)
2024-02-01 [email protected] [Impeller] Remove unused define. (flutter/engine#50250)
2024-02-01 [email protected] Add the focus state related methods to the platform dispatcher (flutter/engine#49841)
2024-02-01 [email protected] Fix the output paths of the Web esbuild GN template (flutter/engine#50188)
2024-02-01 [email protected] [Impeller] Delete unnecessary special casing for Vulkan in framebuffer fetch. (flutter/engine#50251)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants