[Impeller] implemented golden image tests for opengles #50146

gaaclarke · 2024-01-29T19:01:53Z

This sets up impeller_golden_tests to run with ANGLE.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2024-01-30T20:48:29Z

This fails now currently when shaders are attempted to be compiled because they are being compiled for OpenGL, not opengles. They have #version 120 in them, not #version 100.

gaaclarke · 2024-01-30T21:31:56Z

This fails now currently when shaders are attempted to be compiled because they are being compiled for OpenGL, not opengles. They have #version 120 in them, not #version 100.

Fixed with impellerc flags.

gaaclarke · 2024-01-31T17:30:24Z

@jonahwilliams I added the flip in on the CPU side that respects Texture::GetYCoordScale. Thanks for pointing that out. I briefly looked into doing the flip on the GPU but it was more involved. We can do that later.

jonahwilliams · 2024-01-31T18:57:00Z

Thanks! it looks like there is a remaining color format issue BGRA vs RGBA?

gaaclarke · 2024-01-31T18:59:10Z

Thanks! it looks like there is a remaining color format issue BGRA vs RGBA?

Yep, looks like it. Is there something in Texture I can used to decide that? Maybe the TextureDescriptor?

gaaclarke · 2024-01-31T19:04:55Z

The conventional wisdom has been that BGRA is faster on some hardware. We should look to make sure we are taking advantage of that in our renderers.

gaaclarke · 2024-01-31T19:08:51Z

Thanks! it looks like there is a remaining color format issue BGRA vs RGBA?

Yep, looks like it. Is there something in Texture I can used to decide that? Maybe the TextureDescriptor?

Yep, the texture descriptor format has the info we want.

The conventional wisdom has been that BGRA is faster on some hardware. We should look to make sure we are taking advantage of that in our renderers.

OpenGLES is the one using RGBA, we should fix that.

gaaclarke · 2024-01-31T19:12:10Z

Thanks! it looks like there is a remaining color format issue BGRA vs RGBA?

Done.

gaaclarke · 2024-01-31T19:27:29Z

The conventional wisdom has been that BGRA is faster on some hardware. We should look to make sure we are taking advantage of that in our renderers.

I've looked into this a bit. For Android RGBA may be better. It's not clear there is a need to change this considering who is using OpenGLES.

flutter-dashboard · 2024-01-31T19:46:58Z

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #50146 at sha 327502b

jonahwilliams

LGTM

It looks like there are a number of goldens on page 3-4 that aren't showing up at all, you should file a tracking issue to investigate if that is specific to the golden harness.

gaaclarke · 2024-01-31T20:30:19Z

Here are the ones that rendered nothing.

impeller_Play_AiksTest_CanRenderClippedLayers_OpenGLES
impeller_Play_AiksTest_ClippedBlurFilterRendersCorrectly_OpenGLES
impeller_Play_AiksTest_GaussianBlurOneDimension_OpenGLES
impeller_Play_AiksTest_CanRenderBackdropBlurHugeSigma_OpenGLES
impeller_Play_AiksTest_CanDrawPaintMultipleTimes_OpenGLES
impeller_Play_AiksTest_CanDrawPaint_OpenGLES
impeller_Play_AiksTest_CanRenderColorFilterWithInvertColorsDrawPaint_OpenGLES
impeller_Play_AiksTest_GaussianBlurRotatedAndClipped_OpenGLES
impeller_Play_AiksTest_ImageFilteredUnboundedSaveLayerWithUnboundedContents_OpenGLES
impeller_Play_AiksTest_CanDrawPaintWithAdvancedBlend_OpenGLES
impeller_Play_AiksTest_SubpassWithClearColorOptimization_OpenGLES
impeller_Play_AiksTest_CanRenderClippedBlur_OpenGLES
impeller_Play_AiksTest_DrawScaledTextWithPerspectiveNoSaveLayer_OpenGLES
impeller_Play_AiksTest_CanRenderLinearGradientMaskBlur_OpenGLES
impeller_Play_AiksTest_GaussianBlurScaledAndClipped_OpenGLES
impeller_Play_AiksTest_CollapsedDrawPaintInSubpass_OpenGLES

I suspect the blur ones are probably covered under flutter/flutter#142355. I'll double check these against Metal since drawing nothing may be the correct behavior in some cases.

Note: I'm going to land the update of the TODO(tbd) in a separate PR because of the overhead of running CI.

jonahwilliams · 2024-01-31T20:39:49Z

SGTM

…tter/engine#50146)

…142656) flutter/engine@5b89189...c83617e 2024-01-31 [email protected] Roll Dart SDK from 1f136c7b962d to 82936dcdaf4f (1 revision) (flutter/engine#50212) 2024-01-31 [email protected] [Impeller] implemented golden image tests for opengles (flutter/engine#50146) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

followup from #50146 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

github-actions bot added the e: impeller label Jan 29, 2024

gaaclarke force-pushed the impeller_opengl_goldens branch from 80d6caa to e4f825b Compare January 30, 2024 16:39

gaaclarke added 3 commits January 30, 2024 09:17

[Impeller] implemented golden image tests for opengles

c73d53a

swapped out proc table to look in angle

ae4c1f0

made sure glfw uses egl so that we get angle

639691e

gaaclarke force-pushed the impeller_opengl_goldens branch from e4f825b to 639691e Compare January 30, 2024 20:25

got the shaders compiling correctly

311f002

gaaclarke added 2 commits January 30, 2024 13:46

fixed linux shader compile flags

528c273

disabled for windows

29d088f

gaaclarke marked this pull request as ready for review January 30, 2024 22:09

This comment was marked as resolved.

Sign in to view

gaaclarke added 5 commits January 30, 2024 14:10

initialized variable

91e459e

set cwd to grab dylibs

97bad11

added opengles compilation

7460ff9

turned off opengles impeller_unittests for now

5752f5d

++

78aa37f

This comment was marked as outdated.

Sign in to view

flutter-dashboard bot added the will affect goldens label Jan 31, 2024

gaaclarke requested review from chinmaygarde and jonahwilliams January 31, 2024 00:44

started flipping the images based on the textures y scale

058bc61

This comment was marked as outdated.

Sign in to view

fixed BGRA vs RGBA

327502b

jonahwilliams approved these changes Jan 31, 2024

View reviewed changes

gaaclarke mentioned this pull request Jan 31, 2024

[Impeller] OpenGLES goldens are failing to produce output flutter/flutter#142639

Closed

14 tasks

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 31, 2024

auto-submit bot merged commit ba3218b into flutter:main Jan 31, 2024

This was referenced Jan 31, 2024

[Impeller] perform golden texture flip on the GPU flutter/flutter#142641

Closed

[Impeller] impeller_dart_unittests fail with opengles on macos flutter/flutter#142642

Open

engine-flutter-autoroll mentioned this pull request Jan 31, 2024

Roll Flutter Engine from 5b89189b8b5f to ba3218b29486 (1 revision) flutter/flutter#142648

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2024

ba3218b29 [Impeller] implemented golden image tests for opengles (flu…

94e0490

…tter/engine#50146)

engine-flutter-autoroll mentioned this pull request Jan 31, 2024

Roll Flutter Engine from 5b89189b8b5f to c83617eee093 (2 revisions) flutter/flutter#142656

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2024

ba3218b29 [Impeller] implemented golden image tests for opengles (flu…

9aa09f0

…tter/engine#50146)

gaaclarke mentioned this pull request Jan 31, 2024

[Impeller] updated todos from opengles golden work #50218

Merged

8 tasks

auto-submit bot pushed a commit that referenced this pull request Feb 1, 2024

[Impeller] updated todos from opengles golden work (#50218)

bc78e2c

followup from #50146 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

[Impeller] implemented golden image tests for opengles #50146

[Impeller] implemented golden image tests for opengles #50146

Uh oh!

Conversation

gaaclarke commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gaaclarke commented Jan 30, 2024

Uh oh!

gaaclarke commented Jan 30, 2024

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

gaaclarke commented Jan 31, 2024

Uh oh!

This comment was marked as outdated.

jonahwilliams commented Jan 31, 2024

Uh oh!

gaaclarke commented Jan 31, 2024

Uh oh!

gaaclarke commented Jan 31, 2024

Uh oh!

gaaclarke commented Jan 31, 2024

Uh oh!

gaaclarke commented Jan 31, 2024

Uh oh!

gaaclarke commented Jan 31, 2024

Uh oh!

flutter-dashboard bot commented Jan 31, 2024

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented Jan 31, 2024

Uh oh!

jonahwilliams commented Jan 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gaaclarke commented Jan 29, 2024 •

edited

Loading