Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jason-simmons
Copy link
Member

Also update some Impeller thread names to fit within that limit.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-simmons jason-simmons force-pushed the fml_thread_max_name_len branch from 63630af to 6c36f58 Compare January 13, 2024 21:03
Also update some Impeller thread names to fit within that limit.
@jason-simmons jason-simmons force-pushed the fml_thread_max_name_len branch from 6c36f58 to fce4a1b Compare January 13, 2024 21:08
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 16, 2024
@auto-submit auto-submit bot merged commit 5256a3b into flutter:main Jan 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 16, 2024
…141638)

flutter/engine@f206573...eab7bd3

2024-01-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manually bump Dart to 3.4.0-34.0.dev" (flutter/engine#49802)
2024-01-16 [email protected] Use the correct impeller-cmake-example mirror (flutter/engine#49791)
2024-01-16 [email protected] [Flutter GPU] Run unittests on CI and fix HostBuffer. (flutter/engine#49789)
2024-01-16 [email protected] [Flutter GPU] Fix playground shader paths. (flutter/engine#49790)
2024-01-16 [email protected] [Windows] Add README (flutter/engine#49779)
2024-01-16 [email protected] Fix typo (flutter/engine#49725)
2024-01-16 [email protected] Truncate thread names on Linux to the maximum allowed length (flutter/engine#49781)
2024-01-16 [email protected] [Impeller] Fix hot reload for shaders on Impeller (flutter/engine#49739)
2024-01-16 [email protected] Add `flutter` prefix to import (flutter/engine#49793)
2024-01-16 [email protected] Support running sound null safe kernels from dart_runner (flutter/engine#49598)
2024-01-16 [email protected] Manually bump Dart to 3.4.0-34.0.dev (flutter/engine#49792)
2024-01-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.1.0 (flutter/engine#49788)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants