This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support running sound null safe kernels from dart_runner #49598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
iinozemtsev
force-pushed
the
sound_dart_runner
branch
2 times, most recently
from
4918022 to
9c3ef9d
Compare
8 tasks
|
LGTM |
apwilson
approved these changes
Jan 11, 2024
Also switch to core snapshots from core-jit snapshots. See b/315776399
iinozemtsev
force-pushed
the
sound_dart_runner
branch
from
9c3ef9d to
3217836
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 16, 2024
…141638) flutter/engine@f206573...eab7bd3 2024-01-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manually bump Dart to 3.4.0-34.0.dev" (flutter/engine#49802) 2024-01-16 [email protected] Use the correct impeller-cmake-example mirror (flutter/engine#49791) 2024-01-16 [email protected] [Flutter GPU] Run unittests on CI and fix HostBuffer. (flutter/engine#49789) 2024-01-16 [email protected] [Flutter GPU] Fix playground shader paths. (flutter/engine#49790) 2024-01-16 [email protected] [Windows] Add README (flutter/engine#49779) 2024-01-16 [email protected] Fix typo (flutter/engine#49725) 2024-01-16 [email protected] Truncate thread names on Linux to the maximum allowed length (flutter/engine#49781) 2024-01-16 [email protected] [Impeller] Fix hot reload for shaders on Impeller (flutter/engine#49739) 2024-01-16 [email protected] Add `flutter` prefix to import (flutter/engine#49793) 2024-01-16 [email protected] Support running sound null safe kernels from dart_runner (flutter/engine#49598) 2024-01-16 [email protected] Manually bump Dart to 3.4.0-34.0.dev (flutter/engine#49792) 2024-01-16 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.3 to 4.1.0 (flutter/engine#49788) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before starting an isolate,
dart[_test]_component_controllerdetects sound null safety status for all given kernels and fails if they aren't the same, and uses the result to setnull_safetyin isolate flags.Also switch to
coresnapshots fromcore-jitsnapshots, based on #30744, as it looks likecore-jitsnapshots are not null safety agnostic.See b/315776399
Pre-launch Checklist
///).