[Impeller] write vertices geometry data to host buffer. #49741
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
changed the title
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
hmm, I should remove the extra allocations with the allocate callback too. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
oops, broke stuff |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
I'm super ready to smack that approve button as soon as the goldens look good. 😄 |
|
I apparently forgot how this code worked, but it should be fixed. |
|
It happens to the best of us. |
jonahwilliams
added
the
autosubmit
…142252) flutter/engine@55eefd5...b2167a9 2024-01-25 [email protected] [Impeller] write vertices geometry data to host buffer. (flutter/engine#49741) 2024-01-25 [email protected] Revert "[Impeller] round up subpass coverage when it is close to (and smaller) than root pass size." (flutter/engine#50041) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Now that host buffer writes go directly to device buffers, there is no advantage to creating dedicated device buffers for the vertices contents.
Fixes flutter/flutter#141202