[fuchsia] Wire through the tzdata-icu capability

[filmil]

The tzdata-icu capability is a directory containing
ICU time zone resource files. These are requried for
correct computation of local times.

Issue: flutter/flutter#139952

Pre-launch Checklist

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• I read the [Tree Hygiene] wiki page, which explains my responsibilities.
• I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
• I listed at least one issue that this PR fixes in the description above.
• I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
• I updated/added relevant documentation (doc comments with ///).
• I signed the [CLA].
• All existing and new tests are passing.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[tarobins]

LGTM

[tarobins]

i lgtm'd it, but if it's not super critical to get this in now, might want to wait till the new year. Capability routing sometimes breaks things, and with fuchsia/flutter engine, tracking down and reverting can be a pain. And if this happens to break something during the holidays, it'll be harder to get help to fix it.

[filmil]

It’s not urgent no worries.

…

On Thu, Dec 21, 2023 at 4:41 PM Tom Robinson ***@***.***> wrote: i lgtm'd it, but if it's not super critical to get this in now, might want to wait till the new year. Capability routing sometimes breaks things, and with fuchsia/flutter engine, tracking down and reverting can be a pain. And if this happens to break something during the holidays, it'll be harder to get help to fix it. — Reply to this email directly, view it on GitHub <#48907 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB4GMHMITIVTZRLVFWPL2TYKTJMBAVCNFSM6AAAAABAQU6GA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRXGA4TCMBQGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[flutter-dashboard]

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

[chinmaygarde]

Can we land this? The CI failure need a rebase. You can use the GitHub UI to do this automatically.

[filmil]

Let me revisit the comments and retry.

[filmil]

This is now rebased - waiting for the presubmits to pass, and if they do I think this can be merged.

[auto-submit]

auto label is removed for flutter/engine/48907, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

• Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.