Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 9dded18

Browse files
authored
[fuchsia] Wire through the tzdata-icu capability (#48907)
The `tzdata-icu` capability is a directory containing ICU time zone resource files. These are requried for correct computation of local times. Issue: flutter/flutter#139952 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing.
1 parent 3f3eb0d commit 9dded18

File tree

6 files changed

+42
-2
lines changed

6 files changed

+42
-2
lines changed

shell/platform/fuchsia/dart_runner/meta/common.shard.cml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
},
1414
],
1515
use: [
16-
// This is used by the Dart VM to communicate from Dart code to C++ code.
16+
// This is used by the Dart VM to communicate from Dart code to C++ code.
1717
{
1818
storage: "tmp",
1919
path: "/tmp",
@@ -24,6 +24,14 @@
2424
rights: [ "r*" ],
2525
path: "/config/data",
2626
},
27+
// The ICU time zone data, factored out of `config-data`.
28+
// See:
29+
// https://fuchsia.dev/fuchsia-src/concepts/process/namespaces?typical_directory_structure
30+
{
31+
directory: "tzdata-icu",
32+
rights: [ "r*" ],
33+
path: "/config/tzdata/icu",
34+
},
2735
{
2836
protocol: [
2937
"fuchsia.device.NameProvider", // For fdio uname()

shell/platform/fuchsia/dart_runner/tests/startup_integration_test/dart_jit_runner/meta/dart-jit-runner-integration-test.cml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,12 @@
3636
from: "framework",
3737
to: "#realm_builder",
3838
},
39+
// See common.shard.cml.
40+
{
41+
directory: "tzdata-icu",
42+
from: "framework",
43+
to: "#realm_builder",
44+
},
3945
],
4046
// TODO(https://fxbug.dev/114584): Figure out how to bring these in as deps (if possible oot).
4147
facets: {

shell/platform/fuchsia/flutter/meta/common.shard.cml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
},
1414
],
1515
use: [
16-
// This is used by the Dart VM to communicate from Dart code to C++ code.
16+
// This is used by the Dart VM to communicate from Dart code to C++ code.
1717
{
1818
storage: "tmp",
1919
path: "/tmp",
@@ -24,6 +24,14 @@
2424
rights: [ "r*" ],
2525
path: "/config/data",
2626
},
27+
// The ICU time zone data, factored out of `config-data`.
28+
// See:
29+
// https://fuchsia.dev/fuchsia-src/concepts/process/namespaces?typical_directory_structure
30+
{
31+
directory: "tzdata-icu",
32+
rights: [ "r*" ],
33+
path: "/config/tzdata/icu",
34+
},
2735
{
2836
directory: "root-ssl-certificates",
2937
rights: [ "r*" ],

shell/platform/fuchsia/flutter/tests/integration/embedder/parent-view/meta/parent-view.cml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,12 @@
2626
rights: [ "r*" ],
2727
path: "/config/data",
2828
},
29+
// See common.shard.cml.
30+
{
31+
directory: "tzdata-icu",
32+
rights: [ "r*" ],
33+
path: "/config/tzdata/icu",
34+
},
2935
],
3036
expose: [
3137
{

shell/platform/fuchsia/flutter/tests/integration/mouse-input/meta/mouse-input-test.cml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,12 @@
5050
from: "framework",
5151
to: "#realm_builder",
5252
},
53+
// See common.shard.cml.
54+
{
55+
directory: "tzdata-icu",
56+
from: "framework",
57+
to: "#realm_builder",
58+
},
5359
],
5460
// TODO(https://fxbug.dev/114584): Figure out how to bring these in as deps (if possible oot).
5561
facets: {

shell/platform/fuchsia/flutter/tests/integration/text-input/meta/text-input-test.cml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,12 @@
5252
from: "framework",
5353
to: "#realm_builder",
5454
},
55+
// See common.shard.cml.
56+
{
57+
directory: "tzdata-icu",
58+
from: "framework",
59+
to: "#realm_builder",
60+
},
5561
],
5662
// TODO(https://fxbug.dev/114584): Figure out how to bring these in as deps (if possible oot).
5763
facets: {

0 commit comments

Comments
 (0)