This repository was archived by the owner on Feb 25, 2025. It is now read-only.
FontVariation.lerp, custom FontVariation constructors, and more documentation #45030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation This should aid with implementing the framework side of flutter/flutter#105120 This should also address flutter/flutter#28543.
Contributor
Author
|
I actually ran the framework |
eyebrowsoffire
added a commit
to eyebrowsoffire/flutter
that referenced
this pull request
Aug 24, 2023
eyebrowsoffire
approved these changes
Aug 24, 2023
Contributor
There was a problem hiding this comment.
LGTM. I ran a test run here (flutter/flutter#133288), and the only failures are the expected ones (to block us from committing an engine realm file, and some of the Fuchsia CI) and some other flake that doesn't look related. Hopefully this should roll into the framework smoothly🤞
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 25, 2023
…133320) flutter/engine@0f89622...cb58abd 2023-08-25 [email protected] Roll Skia from f867f82cc758 to 8a26fe31389d (1 revision) (flutter/engine#45104) 2023-08-25 [email protected] Roll Skia from 5a1b6567544c to f867f82cc758 (2 revisions) (flutter/engine#45102) 2023-08-25 [email protected] FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#45030) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…entation (flutter#45030) This should aid with implementing the framework side of flutter/flutter#105120. This should also address flutter/flutter#28543. Original commit in flutter#43750 was reverted in flutter#44993. Second attempt in flutter#44996 was reverted in flutter#45023.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should aid with implementing the framework side of flutter/flutter#105120.
This should also address flutter/flutter#28543.
Original commit in #43750 was reverted in #44993.
Second attempt in #44996 was reverted in #45023.