This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" #44993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
approved these changes
Aug 23, 2023
zanderso
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2023
…rs, and more documentation" (flutter/engine#44993)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2023
…rs, and more documentation" (flutter/engine#44993)
Contributor
|
@zanderso when reverting PRs please do let the person whose PR was reverted know; I would never have noticed if I hadn't been trying to fix a typo someone else reported in this PR. |
Contributor
|
Ah I see you requested my review; I had not noticed that because so many people request my review on so many PRs that I have to just ignore that signal. 😅 |
Contributor
|
Reland in #44996. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2023
…rs, and more documentation" (flutter/engine#44993)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2023
…rs, and more documentation" (flutter/engine#44993)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2023
…rs, and more documentation" (flutter/engine#44993)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 23, 2023
…133139) flutter/engine@7d56840...72a0642 2023-08-23 [email protected] Roll Skia from ee7404db8273 to d0c369eaa637 (1 revision) (flutter/engine#44997) 2023-08-23 [email protected] Roll Skia from d0d2b7042bb9 to ee7404db8273 (1 revision) (flutter/engine#44995) 2023-08-23 [email protected] Roll Skia from eac8f8ea2660 to d0d2b7042bb9 (1 revision) (flutter/engine#44994) 2023-08-23 [email protected] Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" (flutter/engine#44993) 2023-08-23 [email protected] Roll Skia from aa208c8a2d60 to eac8f8ea2660 (1 revision) (flutter/engine#44992) 2023-08-23 [email protected] Move Rasterizer::Draw's discard_callback to Delegate (flutter/engine#44813) 2023-08-23 [email protected] FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#43750) 2023-08-23 [email protected] Make web tests start with an empty title (flutter/engine#43846) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
Author
|
@Hixie Sorry about that! Next time I'll ping you on Discord =) |
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
…entation (#45030) This should aid with implementing the framework side of flutter/flutter#105120. This should also address flutter/flutter#28543. Original commit in #43750 was reverted in #44993. Second attempt in #44996 was reverted in #45023.
8 tasks
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…re documentation" (flutter#44993) Reverts flutter#43750 Looks like this is having trouble rolling into the framework: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62845/overview
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…entation (flutter#45030) This should aid with implementing the framework side of flutter/flutter#105120. This should also address flutter/flutter#28543. Original commit in flutter#43750 was reverted in flutter#44993. Second attempt in flutter#44996 was reverted in flutter#45023.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #43750
Looks like this is having trouble rolling into the framework: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/62845/overview