[Impeller] Do not build scene unless 3d define is true #45028

dnfield · 2023-08-23T21:36:49Z

flutter-dashboard · 2023-08-23T21:36:51Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jonahwilliams

LGTM

auto-submit · 2023-08-23T22:07:12Z

auto label is removed for flutter/engine/45028, due to - The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

bdero · 2023-08-24T00:18:47Z

impeller/aiks/aiks_unittests.cc

  ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
 }

+#if IMPELLER_ENABLE_3D


We should activate this flag in a CI build as part of this patch, otherwise Scene will just bitrot.

I've updated the mac unpt build (which AFAIU runs the impeller unittests) to add --impeller-enable-3d.

bdero · 2023-08-24T01:39:21Z

ci/builders/mac_unopt.json

                "--no-lto",
-                "--prebuilt-dart-sdk"
+                "--prebuilt-dart-sdk",
+                "--impeller-enable-3d"


Will this unopt build get collected into artifacts that are shipped to Flutter users in any form? The --impeller-enable-3d flag also switches on the "experimental" version of dart:ui, which allows for appending scene nodes that we should continue not exposing to Flutter users.

we don't ship unopt artifacts

zanderso · 2023-08-24T01:54:39Z

ci/builders/mac_unopt.json

                "--no-lto",
-                "--prebuilt-dart-sdk"
+                "--prebuilt-dart-sdk",
+                "--impeller-enable-3d"


The command to run tests for host_debug_unopt is defined down on line 167. Are there any additional tests to add there?

as long as impeller_unittests runs it's fine - which it should as part of run_tests.py on this platform

dnfield · 2023-08-24T17:41:51Z

I'ms eeing a vulkan validation failure on mac with this patch and don't know why - I'm trying to update to ToT and see if that fixes things.

dnfield · 2023-08-24T17:42:25Z

Coincidentally this is the same fraembuffer issue as we're seeing on the A02...

dnfield · 2023-08-24T17:42:39Z

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8771905154412618609/+/u/test:_Host_Tests_for_host_debug/stdout#L9210_12

dnfield · 2023-08-24T18:12:28Z

Ok, I backed out an unintentional file.

dnfield · 2023-08-24T18:19:59Z

Here's a CI build that ran the Scene unit test:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8771859664658821969/+/u/test:_Host_Tests_for_host_debug_unopt/stdout#L9477_1

auto-submit · 2023-08-24T18:29:23Z

auto label is removed for flutter/engine/45028, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

chinmaygarde · 2023-08-24T20:02:39Z

The web framework test failure seemed like a flake. Retrying.

auto-submit · 2023-08-24T20:53:06Z

auto label is removed for flutter/engine/45028, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

…tter/engine#45028)

…133296) flutter/engine@965501a...b8ec4da 2023-08-24 [email protected] Roll Skia from 99a76ea8e1b2 to 1428f16fc0de (1 revision) (flutter/engine#45086) 2023-08-24 [email protected] Roll Skia from 25fafff5b32c to 99a76ea8e1b2 (2 revisions) (flutter/engine#45083) 2023-08-24 [email protected] Revert "Turn on the `skia_enable_optimize_size` flag to save a bit of binary size" (flutter/engine#45082) 2023-08-24 [email protected] Roll Skia from d7d56885a49b to 25fafff5b32c (1 revision) (flutter/engine#45081) 2023-08-24 [email protected] [Impeller] Do not build scene unless 3d define is true (flutter/engine#45028) 2023-08-24 [email protected] Roll Skia from 177e8477faf9 to d7d56885a49b (1 revision) (flutter/engine#45078) 2023-08-24 [email protected] Reland: [Rasterizer] Make resubmit information temporary (flutter/engine#45037) 2023-08-24 [email protected] Add case checking to android sdk cipd upload script (flutter/engine#45063) 2023-08-24 [email protected] Roll Skia from 007386294889 to 177e8477faf9 (1 revision) (flutter/engine#45076) 2023-08-24 [email protected] Turn on the `skia_enable_optimize_size` flag to save a bit of binary size (flutter/engine#45029) 2023-08-24 [email protected] Roll Skia from b17ee34f3378 to 007386294889 (1 revision) (flutter/engine#45075) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes flutter/flutter#133193

[Impeller] Do not build scene unless 3d define is true

2fb18cf

dnfield requested review from bdero and jonahwilliams August 23, 2023 21:36

github-actions bot added platform-android e: impeller labels Aug 23, 2023

jonahwilliams approved these changes Aug 23, 2023

View reviewed changes

dnfield added 4 commits August 23, 2023 14:41

fix

6913bc8

more

24b7ff1

more

2589276

format

02580cf

dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2023

chinmaygarde assigned dnfield Aug 23, 2023

dnfield added 2 commits August 23, 2023 15:52

skip 3d test if no 3d

97065b1

Merge remote-tracking branch 'upstream/main' into 3d

0d1d87a

bdero suggested changes Aug 24, 2023

View reviewed changes

test 3d on mac unopt, update malioc

9ab6107

bdero reviewed Aug 24, 2023

View reviewed changes

bdero approved these changes Aug 24, 2023

View reviewed changes

zanderso reviewed Aug 24, 2023

View reviewed changes

dnfield added 3 commits August 23, 2023 22:04

option name

79fcdbd

config

a183a3e

Merge branch 'main' into 3d

36c9dca

dnfield added 2 commits August 24, 2023 10:45

Unintended change

6260b35

Merge branch '3d' of github.com:dnfield/engine into 3d

4a268b1

dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023

chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023

dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023

auto-submit bot merged commit 415bb28 into flutter:main Aug 24, 2023

dnfield deleted the 3d branch August 24, 2023 21:52

engine-flutter-autoroll mentioned this pull request Aug 24, 2023

Roll Flutter Engine from 965501a25d92 to 8417a45b2f95 (9 revisions) flutter/flutter#133290

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2023

415bb28fb [Impeller] Do not build scene unless 3d define is true (flu…

1c6b906

…tter/engine#45028)

engine-flutter-autoroll mentioned this pull request Aug 24, 2023

Roll Flutter Engine from 965501a25d92 to 63898d56791a (10 revisions) flutter/flutter#133291

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2023

415bb28fb [Impeller] Do not build scene unless 3d define is true (flu…

c38479b

…tter/engine#45028)

engine-flutter-autoroll mentioned this pull request Aug 24, 2023

Roll Flutter Engine from 965501a25d92 to b8ec4da8866c (11 revisions) flutter/flutter#133296

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2023

415bb28fb [Impeller] Do not build scene unless 3d define is true (flu…

77856d8

…tter/engine#45028)

reidbaker mentioned this pull request Aug 25, 2023

Update to very new gradle version #45124

Closed

8 tasks

gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023

[Impeller] Do not build scene unless 3d define is true (flutter#45028)

4fae4d5

Fixes flutter/flutter#133193

[Impeller] Do not build scene unless 3d define is true #45028

[Impeller] Do not build scene unless 3d define is true #45028

Uh oh!

Conversation

dnfield commented Aug 23, 2023

Uh oh!

flutter-dashboard bot commented Aug 23, 2023

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Aug 23, 2023

Uh oh!

bdero Aug 24, 2023

Choose a reason for hiding this comment

Uh oh!

dnfield Aug 24, 2023

Choose a reason for hiding this comment

Uh oh!

bdero Aug 24, 2023

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Aug 24, 2023

Choose a reason for hiding this comment

Uh oh!

zanderso Aug 24, 2023

Choose a reason for hiding this comment

Uh oh!

dnfield Aug 24, 2023

Choose a reason for hiding this comment

Uh oh!

dnfield commented Aug 24, 2023

Uh oh!

dnfield commented Aug 24, 2023

Uh oh!

dnfield commented Aug 24, 2023

Uh oh!

dnfield commented Aug 24, 2023

Uh oh!

dnfield commented Aug 24, 2023

Uh oh!

auto-submit bot commented Aug 24, 2023

Uh oh!

chinmaygarde commented Aug 24, 2023

Uh oh!

auto-submit bot commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants