Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented Aug 24, 2023

See flutter/flutter#131901 (comment) for the reason for this PR.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall gmackall marked this pull request as ready for review August 24, 2023 15:21
@gmackall gmackall requested review from a team and reidbaker August 24, 2023 15:26
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023
@auto-submit auto-submit bot merged commit 9db6417 into flutter:main Aug 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 25, 2023
…133296)

flutter/engine@965501a...b8ec4da

2023-08-24 [email protected] Roll Skia from 99a76ea8e1b2 to 1428f16fc0de (1 revision) (flutter/engine#45086)
2023-08-24 [email protected] Roll Skia from 25fafff5b32c to 99a76ea8e1b2 (2 revisions) (flutter/engine#45083)
2023-08-24 [email protected] Revert "Turn on the `skia_enable_optimize_size` flag to save a bit of binary size" (flutter/engine#45082)
2023-08-24 [email protected] Roll Skia from d7d56885a49b to 25fafff5b32c (1 revision) (flutter/engine#45081)
2023-08-24 [email protected] [Impeller] Do not build scene unless 3d define is true (flutter/engine#45028)
2023-08-24 [email protected] Roll Skia from 177e8477faf9 to d7d56885a49b (1 revision) (flutter/engine#45078)
2023-08-24 [email protected] Reland: [Rasterizer] Make resubmit information temporary (flutter/engine#45037)
2023-08-24 [email protected] Add case checking to android sdk cipd upload script (flutter/engine#45063)
2023-08-24 [email protected] Roll Skia from 007386294889 to 177e8477faf9 (1 revision) (flutter/engine#45076)
2023-08-24 [email protected] Turn on the `skia_enable_optimize_size` flag to save a bit of binary size (flutter/engine#45029)
2023-08-24 [email protected] Roll Skia from b17ee34f3378 to 007386294889 (1 revision) (flutter/engine#45075)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants