Eliminate android test log spam #44982

reidbaker · 2023-08-22T22:36:41Z

Set gradle to treat warnings as errors and suppress or fix all warnings in engine android tests.

After doing this work I was disappointed to realized that the only lint turned on was deprecration but this is still a step in the right direction.

Remove usages of deprecated junit.framework and replace with org.junit in KeyboardManagerTest, PlatformViewsControllerTest and SinglePresentationViewTest
Annotate deprecated usages of Registrar
Suppress warnings for getSystemWindowInsets and ensure roboletric config consistant with targetApi lint annotation, bump itDescribesTextFieldsWithTextAndHint to 28 because test actually fails on api 26
Suppress warnings for DartExecutor.send
Suppress warnings for ClipboardManager.set/hasText
Suppress warnings for getWindowSystemUiVisibility, setMessageHandler, DartExecutor.send, InputMethodSubtype, and proof of concept migration from Roboletric.setupActivity
Suppress deprecation warnings, set minsdk on tests that were checking for sdk version
Suppress deprecation warnings in SpellCheckPluginTest
Suppress deprecation warnings in MouseCursorPluginTest, set minsdk config to match target api
Stop calling RuntimeEnvrionment.application and insted a call ApplicationProvider.getApplicationContext() in SingleViewPresentationTest
Start calling FlutterView(Context, FlutterSurfaceView)
Suppress deprecation warnings in PlatformPluginTest, getText, Robolectric.setup/buildActivity, system ui flags
Suppress deprecation warnings in PlayStoreDeferredComponentManagerTest
Suppress deprecation warnings in KeyboardChannelTest
Suppress deprecation warnings in SettingsChannelTest
Suppress deprecation warnings in ApplicationInfoLoaderTest
Stop calling RuntimeEnvrionment.application and insted a call ApplicationProvider.getApplicationContext() in FlutterEngineGroupCacheTest
Suppress deprecation warnings in FlutterAndroidComponentTest
Suppress deprecation warnings in FlutterFragmentTest, more robolectric setup activity calls
Suppress deprecation warnings in FlutterActivityAndFragmentDelegateTest
Shadow.directlyOn is incompatible with java 17+, refactor to use reflectors and direct following https://github.com/robolectric/robolectric/pull/6598/files as an example Unsure if SplashShadowResources is used anywhere
Enable warnings as errors
Formatting

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the [CLA].
All existing and new tests are passing.

…t in KeyboardManagerTest, PlatformViewsControllerTest and SinglePresentationViewTest

…fig consistant with targetApi lint annotation, bump itDescribesTextFieldsWithTextAndHint to 28 because test actually fails on api 26

… DartExecutor.send, InputMethodSubtype, and proof of concept migration from Roboletric.setupActivity

… for sdk version

…nfig to match target api

…tionProvider.getApplicationContext() in SingleViewPresentationTest

…tric.setup/buildActivity, system ui flags

…tionProvider.getApplicationContext() in FlutterEngineGroupCacheTest

…c setup activity calls

refactor to use reflectors and direct following https://github.com/robolectric/robolectric/pull/6598/files as an example Unsure if SplashShadowResources is used anywhere

stuartmorgan-g

Various small suggestions, but LGTM as a good step toward having fewer warnings!

stuartmorgan-g · 2023-08-22T23:46:44Z

...atform/android/test/io/flutter/embedding/android/FlutterActivityAndFragmentDelegateTest.java

  private FlutterActivityAndFragmentDelegate.Host mockHost;

+  @SuppressWarnings("deprecation")
+  // Robolectric.setupActivity


Consider extracting a Activity GetMockActivity() or similar that returns Robolectric.setupActivity(Activity.class) so you aren't suppressing the entire method.

...atform/android/test/io/flutter/embedding/android/FlutterActivityAndFragmentDelegateTest.java

stuartmorgan-g · 2023-08-22T23:47:13Z

shell/platform/android/test/io/flutter/embedding/android/FlutterAndroidComponentTest.java

    verify(delegate, never()).detachFromFlutterEngine();
  }

+  @SuppressWarnings("deprecation")


stuartmorgan-g · 2023-08-22T23:47:16Z

shell/platform/android/test/io/flutter/embedding/android/FlutterFragmentTest.java

    assertEquals(fragment.getExclusiveAppComponent(), delegate);
  }

+  @SuppressWarnings("deprecation")


stuartmorgan-g · 2023-08-22T23:48:56Z

shell/platform/android/test/io/flutter/embedding/android/SplashShadowResources.java

+import org.robolectric.util.reflector.ForType;

+@SuppressWarnings("deprecation")
+// getDrawableInt


Do you mean getDrawable(int)? There's no getDrawableInt in this code.

stuartmorgan-g · 2023-08-22T23:51:09Z

shell/platform/android/test/io/flutter/embedding/engine/systemchannels/KeyboardChannelTest.java

  }

+  @SuppressWarnings("deprecation")
+  // setMessageHandler is deprecated.


Is there an issue we can reference for this? If we have a test verifying that our own code is calling our own deprecated method, it seems like there's a problem somewhere.

stuartmorgan-g · 2023-08-22T23:51:42Z

shell/platform/android/test/io/flutter/embedding/engine/systemchannels/SettingsChannelTest.java

  @TargetApi(33)
  @Config(sdk = 33)
+  @SuppressWarnings("deprecation")
+  // DartExecutor.send is deprecated.


Can we reference an issue for all of these deprecated send calls (here and in other files)?

shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java

stuartmorgan-g · 2023-08-22T23:53:14Z

shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java

      return;
    }
-
+    // Migrate to ActivityScenario by following https://github.com/robolectric/robolectric/pull/4736


This looks like it should be a // TODO

stuartmorgan-g · 2023-08-22T23:54:08Z

shell/platform/android/test_runner/build.gradle

 gradle.projectsEvaluated {
  tasks.withType(JavaCompile) {
-      options.compilerArgs << "-Xlint:deprecation" << "-Xmaxwarns" << "434"
+      options.compilerArgs << "-Xlint:deprecation" << "-Werror" << "-Xmaxwarns" << "434"


Do you want to include a TODO with an issue link for adding more lint options?

…om buildActivity methods

…number of supressed warnings

One change was missing from #44982 when I applied auto submit.

…133211) flutter/engine@58dc868...27d75f6 2023-08-23 [email protected] Roll Skia from 76898dad9fda to a631fefdba37 (2 revisions) (flutter/engine#45027) 2023-08-23 [email protected] Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" (flutter/engine#45023) 2023-08-23 [email protected] [Impeller] Dat rvalue reference (fix engine head) (flutter/engine#45024) 2023-08-23 [email protected] Revert "Enable clang-tidy for pre-push (opt-out), exclude `performance-unnecessary-value-param`" (flutter/engine#45020) 2023-08-23 [email protected] Roll Skia from 4e42b51cfe27 to 76898dad9fda (1 revision) (flutter/engine#45019) 2023-08-23 [email protected] [Impeller] Add STB text backend. (flutter/engine#44887) 2023-08-23 [email protected] Followup to flutter/engine#44982 (flutter/engine#45018) 2023-08-23 [email protected] Roll Skia from 5428f147e632 to 4e42b51cfe27 (4 revisions) (flutter/engine#45016) 2023-08-23 [email protected] Eliminate android test log spam (flutter/engine#44982) 2023-08-23 [email protected] [web] Remove some unused functions (flutter/engine#44505) 2023-08-23 [email protected] Use decal TileMode in blur image_filter_test.dart (flutter/engine#45004) 2023-08-23 [email protected] FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#44996) 2023-08-23 [email protected] [impeller] combine sampler and texture maps. (flutter/engine#44990) 2023-08-23 [email protected] [Impeller] Flutter GPU: Add HostBuffer. (flutter/engine#44696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Set gradle to treat warnings as errors and suppress or fix all warnings in engine android tests. Fixes flutter/flutter/133070 After doing this work I was disappointed to realized that the only lint turned on was deprecration but this is still a step in the right direction. - Remove usages of deprecated junit.framework and replace with org.junit in KeyboardManagerTest, PlatformViewsControllerTest and SinglePresentationViewTest - Annotate deprecated usages of Registrar - Suppress warnings for getSystemWindowInsets and ensure roboletric config consistant with targetApi lint annotation, bump itDescribesTextFieldsWithTextAndHint to 28 because test actually fails on api 26 - Suppress warnings for DartExecutor.send - Suppress warnings for ClipboardManager.set/hasText - Suppress warnings for getWindowSystemUiVisibility, setMessageHandler, DartExecutor.send, InputMethodSubtype, and proof of concept migration from Roboletric.setupActivity - Suppress deprecation warnings, set minsdk on tests that were checking for sdk version - Suppress deprecation warnings in SpellCheckPluginTest - Suppress deprecation warnings in MouseCursorPluginTest, set minsdk config to match target api - Stop calling RuntimeEnvrionment.application and insted a call ApplicationProvider.getApplicationContext() in SingleViewPresentationTest - Start calling FlutterView(Context, FlutterSurfaceView) - Suppress deprecation warnings in PlatformPluginTest, getText, Robolectric.setup/buildActivity, system ui flags - Suppress deprecation warnings in PlayStoreDeferredComponentManagerTest - Suppress deprecation warnings in KeyboardChannelTest - Suppress deprecation warnings in SettingsChannelTest - Suppress deprecation warnings in ApplicationInfoLoaderTest - Stop calling RuntimeEnvrionment.application and insted a call ApplicationProvider.getApplicationContext() in FlutterEngineGroupCacheTest - Suppress deprecation warnings in FlutterAndroidComponentTest - Suppress deprecation warnings in FlutterFragmentTest, more robolectric setup activity calls - Suppress deprecation warnings in FlutterActivityAndFragmentDelegateTest - Shadow.directlyOn is incompatible with java 17+, refactor to use reflectors and direct following https://github.com/robolectric/robolectric/pull/6598/files as an example Unsure if SplashShadowResources is used anywhere - Enable warnings as errors - Formatting

One change was missing from flutter#44982 when I applied auto submit.

reidbaker added 23 commits August 22, 2023 15:19

Remove usages of deprecated junit.framework and replace with org.juni…

69dfefb

…t in KeyboardManagerTest, PlatformViewsControllerTest and SinglePresentationViewTest

Annotate deprecated usages of Registrar

5925883

Suppress warnings for getSystemWindowInsets and ensure roboletric con…

b3ada37

…fig consistant with targetApi lint annotation, bump itDescribesTextFieldsWithTextAndHint to 28 because test actually fails on api 26

Suppress warnings for DartExecutor.send

1f2bc15

Suppress warnings for ClipboardManager.set/hasText

0d3b2b0

Suppress warnings for getWindowSystemUiVisibility, setMessageHandler,…

9f2b588

… DartExecutor.send, InputMethodSubtype, and proof of concept migration from Roboletric.setupActivity

Suppress deprecation warnings, set minsdk on tests that were checking…

86eb955

… for sdk version

Suppress deprecation warnings in SpellCheckPluginTest

8a482fc

Suppress deprecation warnings in MouseCursorPluginTest, set minsdk co…

fb7272d

…nfig to match target api

Stop calling RuntimeEnvrionment.application and insted a call Applica…

90f6ce0

…tionProvider.getApplicationContext() in SingleViewPresentationTest

Start calling FlutterView(Context, FlutterSurfaceView)

d32d874

Suppress deprecation warnings in PlatformPluginTest, getText, Robolec…

7c65622

…tric.setup/buildActivity, system ui flags

Suppress deprecation warnings in PlayStoreDeferredComponentManagerTest

3ba9a98

Suppress deprecation warnings in KeyboardChannelTest

488c707

Suppress deprecation warnings in SettingsChannelTest

78d6b79

Suppress deprecation warnings in ApplicationInfoLoaderTest

0c14a63

Stop calling RuntimeEnvrionment.application and insted a call Applica…

7eb6b01

…tionProvider.getApplicationContext() in FlutterEngineGroupCacheTest

Suppress deprecation warnings in FlutterAndroidComponentTest

e58f957

Suppress deprecation warnings in FlutterFragmentTest, more robolectri…

fb86f96

…c setup activity calls

Suppress deprecation warnings in FlutterActivityAndFragmentDelegateTest

e987bc2

Shadow.directlyOn is incompatible with java 17+,

86d08f5

refactor to use reflectors and direct following https://github.com/robolectric/robolectric/pull/6598/files as an example Unsure if SplashShadowResources is used anywhere

Enable warnings as errors

81cd095

Formatting

6142bf2

reidbaker requested review from johnmccutchan, stuartmorgan-g and zanderso August 22, 2023 22:36

github-actions bot added the platform-android label Aug 22, 2023

stuartmorgan-g approved these changes Aug 22, 2023

View reviewed changes

reidbaker added 2 commits August 23, 2023 11:18

Add todo for roboletric setupActivity method and remove supression fr…

1ea2739

…om buildActivity methods

Add todo for expanding linter coverage and refactor method to reduce …

e281c25

…number of supressed warnings

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2023

reidbaker requested a review from a team August 23, 2023 19:21

auto-submit bot merged commit d35b01f into flutter:main Aug 23, 2023

reidbaker mentioned this pull request Aug 23, 2023

Followup to https://github.com/flutter/engine/pull/44982 #45018

Merged

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 58dc868c26cb to d35b01f16761 (6 revisions) flutter/flutter#133185

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

d35b01f16 Eliminate android test log spam (flutter/engine#44982)

a38a531

auto-submit bot pushed a commit that referenced this pull request Aug 23, 2023

Followup to #44982 (#45018)

a42ddc1

One change was missing from #44982 when I applied auto submit.

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 58dc868c26cb to a2adaa39a2c3 (7 revisions) flutter/flutter#133187

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

d35b01f16 Eliminate android test log spam (flutter/engine#44982)

f94cc89

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 58dc868c26cb to a42ddc1962c4 (8 revisions) flutter/flutter#133192

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

d35b01f16 Eliminate android test log spam (flutter/engine#44982)

ddc2a28

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

a42ddc196 Followup to flutter/engine#44982 (flutter/engine#45018)

621df87

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 58dc868c26cb to a42ddc1962c4 (8 revisions) flutter/flutter#133197

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

d35b01f16 Eliminate android test log spam (flutter/engine#44982)

9c0bf4f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

a42ddc196 Followup to flutter/engine#44982 (flutter/engine#45018)

deea76c

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 58dc868c26cb to be7c280b0e12 (13 revisions) flutter/flutter#133205

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

d35b01f16 Eliminate android test log spam (flutter/engine#44982)

64b30b3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

a42ddc196 Followup to flutter/engine#44982 (flutter/engine#45018)

9e1cf56

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 58dc868c26cb to 27d75f6221d2 (14 revisions) flutter/flutter#133211

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

d35b01f16 Eliminate android test log spam (flutter/engine#44982)

09f7c33

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

a42ddc196 Followup to flutter/engine#44982 (flutter/engine#45018)

209c28d

reidbaker mentioned this pull request Aug 25, 2023

Update to very new gradle version #45124

Closed

8 tasks

gaaclarke pushed a commit to gaaclarke/engine that referenced this pull request Aug 30, 2023

Followup to flutter#44982 (flutter#45018)

50c2964

One change was missing from flutter#44982 when I applied auto submit.

Eliminate android test log spam #44982

Eliminate android test log spam #44982

Uh oh!

Conversation

reidbaker commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

reidbaker commented Aug 22, 2023 •

edited

Loading