Eliminate android test log spam (#44982)

Set gradle to treat warnings as errors and suppress or fix all warnings in engine android tests. 

Fixes flutter/flutter/133070

After doing this work I was disappointed to realized that the only lint turned on was deprecration but this is still a step in the right direction. 

- Remove usages of deprecated junit.framework and replace with org.junit in KeyboardManagerTest, PlatformViewsControllerTest and SinglePresentationViewTest
- Annotate deprecated usages of Registrar
- Suppress warnings for getSystemWindowInsets and ensure roboletric config consistant with targetApi lint annotation, bump itDescribesTextFieldsWithTextAndHint to 28 because test actually fails on api 26
- Suppress warnings for DartExecutor.send
- Suppress warnings for ClipboardManager.set/hasText
- Suppress warnings for getWindowSystemUiVisibility, setMessageHandler, DartExecutor.send, InputMethodSubtype, and proof of concept migration from Roboletric.setupActivity
- Suppress deprecation warnings, set minsdk on tests that were checking for sdk version
- Suppress deprecation warnings in SpellCheckPluginTest
- Suppress deprecation warnings in MouseCursorPluginTest, set minsdk config to match target api
- Stop calling RuntimeEnvrionment.application and insted a call ApplicationProvider.getApplicationContext() in SingleViewPresentationTest
- Start calling FlutterView(Context, FlutterSurfaceView)
- Suppress deprecation warnings in PlatformPluginTest, getText, Robolectric.setup/buildActivity, system ui flags
- Suppress deprecation warnings in PlayStoreDeferredComponentManagerTest
- Suppress deprecation warnings in KeyboardChannelTest
- Suppress deprecation warnings in SettingsChannelTest
- Suppress deprecation warnings in ApplicationInfoLoaderTest
- Stop calling RuntimeEnvrionment.application and insted a call ApplicationProvider.getApplicationContext() in FlutterEngineGroupCacheTest
- Suppress deprecation warnings in FlutterAndroidComponentTest
- Suppress deprecation warnings in FlutterFragmentTest, more robolectric setup activity calls
- Suppress deprecation warnings in FlutterActivityAndFragmentDelegateTest
- Shadow.directlyOn is incompatible with java 17+, refactor to use reflectors and direct following https://github.com/robolectric/robolectric/pull/6598/files as an example Unsure if SplashShadowResources is used anywhere
- Enable warnings as errors
- Formatting

Author: reidbaker

shell/platform/android/test/io/flutter/embedding/android/FlutterActivityAndFragmentDelegateTest.java

@@ -66,6 +66,9 @@ public class FlutterActivityAndFragmentDelegateTest {
   private FlutterEngine mockFlutterEngine;
   private FlutterActivityAndFragmentDelegate.Host mockHost;
 
+  @SuppressWarnings("deprecation")
+  // Robolectric.setupActivity
+  // TODO(reidbaker): https://github.com/flutter/flutter/issues/133151
   @Before
   public void setup() {
     FlutterInjector.reset();
@@ -402,6 +405,9 @@ public void itGivesHostAnOpportunityToConfigureFlutterSurfaceView() {
     verify(mockHost, times(1)).onFlutterSurfaceViewCreated(isNotNull());
   }
 
+  @SuppressWarnings("deprecation")
+  // Robolectric.setupActivity
+  // TODO(reidbaker): https://github.com/flutter/flutter/issues/133151
   @Test
   public void itGivesHostAnOpportunityToConfigureFlutterTextureView() {
     // ---- Test setup ----

shell/platform/android/test/io/flutter/embedding/android/FlutterAndroidComponentTest.java

@@ -265,6 +265,9 @@ public Context getContext() {
       return ApplicationProvider.getApplicationContext();
     }
 
+    @SuppressWarnings("deprecation")
+    // Robolectric.setupActivity
+    // TODO(reidbaker): https://github.com/flutter/flutter/issues/133151
     @Nullable
     @Override
     public Activity getActivity() {

shell/platform/android/test/io/flutter/embedding/android/FlutterFragmentTest.java

@@ -283,6 +283,9 @@ public void itReturnsExclusiveAppComponent() {
     assertEquals(fragment.getExclusiveAppComponent(), delegate);
   }
 
+  @SuppressWarnings("deprecation")
+  // Robolectric.setupActivity
+  // TODO(reidbaker): https://github.com/flutter/flutter/issues/133151
   @Test
   public void itDelegatesOnBackPressedAutomaticallyWhenEnabled() {
     // We need to mock FlutterJNI to avoid triggering native code.
@@ -317,6 +320,9 @@ public void itDelegatesOnBackPressedAutomaticallyWhenEnabled() {
     verify(mockDelegate, times(1)).onBackPressed();
   }
 
+  @SuppressWarnings("deprecation")
+  // Robolectric.setupActivity
+  // TODO(reidbaker): https://github.com/flutter/flutter/issues/133151
   @Test
   public void itHandlesPopSystemNavigationAutomaticallyWhenEnabled() {
     // We need to mock FlutterJNI to avoid triggering native code.

shell/platform/android/test/io/flutter/embedding/android/KeyboardManagerTest.java

@@ -29,7 +29,6 @@
 import java.util.function.BiConsumer;
 import java.util.function.Consumer;
 import java.util.stream.Collectors;
-import junit.framework.Assert;
 import org.json.JSONException;
 import org.json.JSONObject;
 import org.junit.Before;
@@ -489,25 +488,25 @@ public void serializeAndDeserializeKeyData() {
   @Test
   public void basicCombingCharactersTest() {
     final KeyboardManager.CharacterCombiner combiner = new KeyboardManager.CharacterCombiner();
-    Assert.assertEquals(0, (int) combiner.applyCombiningCharacterToBaseCharacter(0));
-    Assert.assertEquals('A', (int) combiner.applyCombiningCharacterToBaseCharacter('A'));
-    Assert.assertEquals('B', (int) combiner.applyCombiningCharacterToBaseCharacter('B'));
-    Assert.assertEquals('B', (int) combiner.applyCombiningCharacterToBaseCharacter('B'));
-    Assert.assertEquals(0, (int) combiner.applyCombiningCharacterToBaseCharacter(0));
-    Assert.assertEquals(0, (int) combiner.applyCombiningCharacterToBaseCharacter(0));
-
-    Assert.assertEquals('`', (int) combiner.applyCombiningCharacterToBaseCharacter(DEAD_KEY));
-    Assert.assertEquals('`', (int) combiner.applyCombiningCharacterToBaseCharacter(DEAD_KEY));
-    Assert.assertEquals('À', (int) combiner.applyCombiningCharacterToBaseCharacter('A'));
-
-    Assert.assertEquals('`', (int) combiner.applyCombiningCharacterToBaseCharacter(DEAD_KEY));
-    Assert.assertEquals(0, (int) combiner.applyCombiningCharacterToBaseCharacter(0));
+    assertEquals(0, (int) combiner.applyCombiningCharacterToBaseCharacter(0));
+    assertEquals('B', (int) combiner.applyCombiningCharacterToBaseCharacter('B'));
+    assertEquals('B', (int) combiner.applyCombiningCharacterToBaseCharacter('B'));
+    assertEquals('A', (int) combiner.applyCombiningCharacterToBaseCharacter('A'));
+    assertEquals(0, (int) combiner.applyCombiningCharacterToBaseCharacter(0));
+    assertEquals(0, (int) combiner.applyCombiningCharacterToBaseCharacter(0));
+
+    assertEquals('`', (int) combiner.applyCombiningCharacterToBaseCharacter(DEAD_KEY));
+    assertEquals('`', (int) combiner.applyCombiningCharacterToBaseCharacter(DEAD_KEY));
+    assertEquals('À', (int) combiner.applyCombiningCharacterToBaseCharacter('A'));
+
+    assertEquals('`', (int) combiner.applyCombiningCharacterToBaseCharacter(DEAD_KEY));
+    assertEquals(0, (int) combiner.applyCombiningCharacterToBaseCharacter(0));
     // The 0 input should remove the combining state.
-    Assert.assertEquals('A', (int) combiner.applyCombiningCharacterToBaseCharacter('A'));
+    assertEquals('A', (int) combiner.applyCombiningCharacterToBaseCharacter('A'));
 
-    Assert.assertEquals(0, (int) combiner.applyCombiningCharacterToBaseCharacter(0));
-    Assert.assertEquals('`', (int) combiner.applyCombiningCharacterToBaseCharacter(DEAD_KEY));
-    Assert.assertEquals('À', (int) combiner.applyCombiningCharacterToBaseCharacter('A'));
+    assertEquals(0, (int) combiner.applyCombiningCharacterToBaseCharacter(0));
+    assertEquals('`', (int) combiner.applyCombiningCharacterToBaseCharacter(DEAD_KEY));
+    assertEquals('À', (int) combiner.applyCombiningCharacterToBaseCharacter('A'));
   }
 
   @Test

shell/platform/android/test/io/flutter/embedding/android/SplashShadowResources.java

@@ -1,5 +1,7 @@
 package io.flutter.embedding.android;
 
+import static org.robolectric.util.reflector.Reflector.reflector;
+
 import android.content.res.Resources;
 import android.graphics.Color;
 import android.graphics.drawable.ColorDrawable;
@@ -8,22 +10,34 @@
 import org.robolectric.annotation.Implementation;
 import org.robolectric.annotation.Implements;
 import org.robolectric.annotation.RealObject;
-import org.robolectric.shadow.api.Shadow;
 import org.robolectric.shadows.ShadowResources;
+import org.robolectric.util.reflector.Direct;
+import org.robolectric.util.reflector.ForType;
 
+@SuppressWarnings("deprecation")
+// getDrawableInt
 @Implements(Resources.class)
 public class SplashShadowResources extends ShadowResources {
   @RealObject private Resources resources;
 
   public static final int SPLASH_DRAWABLE_ID = 191919;
   public static final int THEMED_SPLASH_DRAWABLE_ID = 212121;
 
+  @ForType(Resources.class)
+  interface ResourcesReflector {
+    @Direct
+    Drawable getDrawable(int id, Resources.Theme theme);
+
+    @Direct
+    Drawable getDrawable(int id);
+  }
+
   @Implementation
   protected Drawable getDrawable(int id) {
     if (id == SPLASH_DRAWABLE_ID) {
       return new ColorDrawable(Color.BLUE);
     }
-    return Shadow.directlyOn(resources, Resources.class).getDrawable(id);
+    return reflector(Resources.class, resources).getDrawable(id);
   }
 
   @Implementation
@@ -37,6 +51,6 @@ protected Drawable getDrawable(int id, @Nullable Resources.Theme theme) {
       }
       return new ColorDrawable(Color.GRAY);
     }
-    return Shadow.directlyOn(resources, Resources.class).getDrawable(id, theme);
+    return reflector(Resources.class, resources).getDrawable(id, theme);
   }
 }

shell/platform/android/test/io/flutter/embedding/engine/FlutterEngineGroupCacheTest.java

@@ -7,13 +7,13 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+import androidx.test.core.app.ApplicationProvider;
 import io.flutter.FlutterInjector;
 import io.flutter.embedding.engine.loader.FlutterLoader;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.robolectric.RobolectricTestRunner;
-import org.robolectric.RuntimeEnvironment;
 import org.robolectric.annotation.Config;
 
 @Config(manifest = Config.NONE)
@@ -75,8 +75,10 @@ public void itRemovesFlutterEngineGroups() {
   @Test
   public void itRemovesAllFlutterEngineGroups() {
     // --- Test Setup ---
-    FlutterEngineGroup flutterEngineGroup1 = new FlutterEngineGroup(RuntimeEnvironment.application);
-    FlutterEngineGroup flutterEngineGroup2 = new FlutterEngineGroup(RuntimeEnvironment.application);
+    FlutterEngineGroup flutterEngineGroup1 =
+        new FlutterEngineGroup(ApplicationProvider.getApplicationContext());
+    FlutterEngineGroup flutterEngineGroup2 =
+        new FlutterEngineGroup(ApplicationProvider.getApplicationContext());
     FlutterEngineGroupCache cache = new FlutterEngineGroupCache();
 
     // --- Execute Test ---

shell/platform/android/test/io/flutter/embedding/engine/deferredcomponents/PlayStoreDeferredComponentManagerTest.java

@@ -83,6 +83,8 @@ public void installDeferredComponent(int loadingUnitId, String componentName) {
     }
   }
 
+  @SuppressWarnings("deprecation")
+  // getApplicationInfo
   private Context createSpyContext(Bundle metadata) throws NameNotFoundException {
     Context spyContext = spy(ApplicationProvider.getApplicationContext());
     doReturn(spyContext).when(spyContext).createPackageContext(any(), anyInt());

shell/platform/android/test/io/flutter/embedding/engine/loader/ApplicationInfoLoaderTest.java

@@ -48,6 +48,8 @@ public void itGeneratesCorrectApplicationInfoWithDefaultManifest() {
     assertNull(info.nativeLibraryDir);
   }
 
+  @SuppressWarnings("deprecation")
+  // getApplicationInfo
   private Context generateMockContext(Bundle metadata, String networkPolicyXml) throws Exception {
     Context context = mock(Context.class);
     PackageManager packageManager = mock(PackageManager.class);

shell/platform/android/test/io/flutter/embedding/engine/plugins/shim/ShimPluginRegistryTest.java

@@ -15,7 +15,6 @@
 import io.flutter.embedding.engine.plugins.PluginRegistry;
 import io.flutter.embedding.engine.plugins.activity.ActivityAware;
 import io.flutter.embedding.engine.plugins.activity.ActivityPluginBinding;
-import io.flutter.plugin.common.PluginRegistry.Registrar;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -43,11 +42,15 @@ public void setup() {
     when(mockActivityPluginBinding.getActivity()).thenReturn(mockActivity);
   }
 
+  @SuppressWarnings("deprecation")
+  // Test is intentionally verifying deprecated behavior.
   @Test
   public void itSuppliesOldAPIsViaTheNewFlutterPluginBinding() {
     ShimPluginRegistry registryUnderTest = new ShimPluginRegistry(mockFlutterEngine);
+    // Fully qualifed name because imports can not have deprecation supression.
     // This is the consumption side of the old plugins.
-    Registrar registrarUnderTest = registryUnderTest.registrarFor("test");
+    io.flutter.plugin.common.PluginRegistry.Registrar registrarUnderTest =
+        registryUnderTest.registrarFor("test");
 
     ArgumentCaptor<FlutterPlugin> shimAggregateCaptor =
         ArgumentCaptor.forClass(FlutterPlugin.class);
@@ -65,11 +68,16 @@ public void itSuppliesOldAPIsViaTheNewFlutterPluginBinding() {
     verify(mockFlutterPluginBinding).getApplicationContext();
   }
 
+  @SuppressWarnings("deprecation")
+  // Test is intentionally verifying deprecated behavior.
   @Test
   public void itSuppliesMultipleOldPlugins() {
     ShimPluginRegistry registryUnderTest = new ShimPluginRegistry(mockFlutterEngine);
-    Registrar registrarUnderTest1 = registryUnderTest.registrarFor("test1");
-    Registrar registrarUnderTest2 = registryUnderTest.registrarFor("test2");
+    // Fully qualifed name because imports can not have deprecation supression.
+    io.flutter.plugin.common.PluginRegistry.Registrar registrarUnderTest1 =
+        registryUnderTest.registrarFor("test1");
+    io.flutter.plugin.common.PluginRegistry.Registrar registrarUnderTest2 =
+        registryUnderTest.registrarFor("test2");
 
     ArgumentCaptor<FlutterPlugin> shimAggregateCaptor =
         ArgumentCaptor.forClass(FlutterPlugin.class);
@@ -86,10 +94,13 @@ public void itSuppliesMultipleOldPlugins() {
     verify(mockFlutterPluginBinding, times(2)).getApplicationContext();
   }
 
+  @SuppressWarnings("deprecation")
+  // Test is intentionally verifying deprecated behavior.
   @Test
   public void itCanOnlySupplyActivityBindingWhenUpstreamActivityIsAttached() {
     ShimPluginRegistry registryUnderTest = new ShimPluginRegistry(mockFlutterEngine);
-    Registrar registrarUnderTest = registryUnderTest.registrarFor("test");
+    io.flutter.plugin.common.PluginRegistry.Registrar registrarUnderTest =
+        registryUnderTest.registrarFor("test");
 
     ArgumentCaptor<FlutterPlugin> shimAggregateCaptor =
         ArgumentCaptor.forClass(FlutterPlugin.class);

shell/platform/android/test/io/flutter/embedding/engine/systemchannels/KeyboardChannelTest.java

@@ -32,6 +32,8 @@ private static BinaryMessenger.BinaryReply sendToBinaryMessageHandler(
     return reply;
   }
 
+  @SuppressWarnings("deprecation")
+  // setMessageHandler is deprecated.
   @Test
   public void respondsToGetKeyboardStateChannelMessage() {
     ArgumentCaptor<BinaryMessenger.BinaryMessageHandler> binaryMessageHandlerCaptor =