Move Rasterizer::Draw's discard_callback to Delegate #44813

dkwingsmt · 2023-08-17T16:30:07Z

This PR Rasterizer::Draw's discard_callback parameter, which is assigned by Shell, to Delegate, which is also implemented by Shell. This refactory makes the API cleaner.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…r-discarding

chinmaygarde

Not sure if this was ready for review just yet but we ran into this in triage. LGTM after the nits.

chinmaygarde · 2023-08-17T20:25:55Z

shell/platform/embedder/tests/embedder_metal_unittests.mm


  auto rendered_scene = context.GetNextSceneImage();

+  printf("main 1\n");fflush(stdout);


Spurious printfs.

…r-discarding

shell/common/rasterizer.cc

loic-sharma · 2023-08-21T20:52:19Z

shell/common/shell.h


+  // |Rasterizer::Delegate|
+  bool ShouldDiscardLayerTree(int64_t view_id,
+                              flutter::LayerTree& tree) override;


Can this be const?

Suggested change

flutter::LayerTree& tree) override;

const flutter::LayerTree& tree) override;

…r-discarding

loic-sharma

LGTM

…er/engine#44813)

…133139) flutter/engine@7d56840...72a0642 2023-08-23 [email protected] Roll Skia from ee7404db8273 to d0c369eaa637 (1 revision) (flutter/engine#44997) 2023-08-23 [email protected] Roll Skia from d0d2b7042bb9 to ee7404db8273 (1 revision) (flutter/engine#44995) 2023-08-23 [email protected] Roll Skia from eac8f8ea2660 to d0d2b7042bb9 (1 revision) (flutter/engine#44994) 2023-08-23 [email protected] Revert "FontVariation.lerp, custom FontVariation constructors, and more documentation" (flutter/engine#44993) 2023-08-23 [email protected] Roll Skia from aa208c8a2d60 to eac8f8ea2660 (1 revision) (flutter/engine#44992) 2023-08-23 [email protected] Move Rasterizer::Draw's discard_callback to Delegate (flutter/engine#44813) 2023-08-23 [email protected] FontVariation.lerp, custom FontVariation constructors, and more documentation (flutter/engine#43750) 2023-08-23 [email protected] Make web tests start with an empty title (flutter/engine#43846) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR `Rasterizer::Draw`'s `discard_callback` parameter, which is assigned by `Shell`, to `Delegate`, which is also implemented by `Shell`. This refactory makes the API cleaner. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I signed the [CLA]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

dkwingsmt added 5 commits August 17, 2023 09:26

Move discard to shell

0370412

Merge remote-tracking branch 'origin/main' into internalize-rasterize…

d639cf2

…r-discarding

WIP: Add logs

a22a197

WIP: more logs, and no assert

782fd30

WIP: More logs

54c31c0

chinmaygarde approved these changes Aug 17, 2023

View reviewed changes

dkwingsmt added 3 commits August 17, 2023 15:04

Merge remote-tracking branch 'origin/main' into internalize-rasterize…

aec3cb1

…r-discarding

Compilable with multiview

0172d76

use weak this

96dc994

dnfield reviewed Aug 21, 2023

View reviewed changes

shell/common/rasterizer.cc Outdated Show resolved Hide resolved

Fix weak_this’s controlling

a9bf24e

loic-sharma reviewed Aug 21, 2023

View reviewed changes

dnfield mentioned this pull request Aug 22, 2023

Initialize the texture destruction callback in the Metal embedder test harness #44973

Merged

dkwingsmt added 2 commits August 22, 2023 16:32

Merge remote-tracking branch 'origin/main' into internalize-rasterize…

498ffd8

…r-discarding

Remove prints

aa0ec10

loic-sharma approved these changes Aug 22, 2023

View reviewed changes

dkwingsmt added 2 commits August 22, 2023 17:04

const ref

32ea381

Remove weak_ptr?

c491896

dkwingsmt force-pushed the internalize-rasterizer-discarding branch from dae8622 to c491896 Compare August 23, 2023 02:12

dkwingsmt merged commit 48a5226 into flutter:main Aug 23, 2023

dkwingsmt deleted the internalize-rasterizer-discarding branch August 23, 2023 04:25

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 7d56840865d2 to 48a5226600e6 (3 revisions) flutter/flutter#133109

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

48a522660 Move Rasterizer::Draw's discard_callback to Delegate (flutt…

0908f4f

…er/engine#44813)

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 7d56840865d2 to 064105761c39 (5 revisions) flutter/flutter#133112

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

48a522660 Move Rasterizer::Draw's discard_callback to Delegate (flutt…

d5d44c9

…er/engine#44813)

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 7d56840865d2 to 933cd22359c8 (6 revisions) flutter/flutter#133113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

48a522660 Move Rasterizer::Draw's discard_callback to Delegate (flutt…

3c08f2f

…er/engine#44813)

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 7d56840865d2 to a73a1a5c413f (7 revisions) flutter/flutter#133117

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

48a522660 Move Rasterizer::Draw's discard_callback to Delegate (flutt…

7d7f0d7

…er/engine#44813)

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 7d56840865d2 to 72a06427bd37 (8 revisions) flutter/flutter#133131

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

48a522660 Move Rasterizer::Draw's discard_callback to Delegate (flutt…

a2d0508

…er/engine#44813)

engine-flutter-autoroll mentioned this pull request Aug 23, 2023

Roll Flutter Engine from 7d56840865d2 to 72a06427bd37 (8 revisions) flutter/flutter#133139

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023

48a522660 Move Rasterizer::Draw's discard_callback to Delegate (flutt…

8874222

…er/engine#44813)

reidbaker mentioned this pull request Aug 25, 2023

Update to very new gradle version #45124

Closed

8 tasks

HansMuller mentioned this pull request Aug 25, 2023

Flutter Framework Team: Notable Commits flutter/flutter#121415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move Rasterizer::Draw's discard_callback to Delegate #44813

Move Rasterizer::Draw's discard_callback to Delegate #44813

Uh oh!

dkwingsmt commented Aug 17, 2023 •

edited

Loading

Uh oh!

chinmaygarde left a comment

Uh oh!

chinmaygarde Aug 17, 2023

Uh oh!

Uh oh!

loic-sharma Aug 21, 2023

Uh oh!

loic-sharma left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		auto rendered_scene = context.GetNextSceneImage();

		printf("main 1\n");fflush(stdout);

	flutter::LayerTree& tree) override;
	const flutter::LayerTree& tree) override;

Move Rasterizer::Draw's discard_callback to Delegate #44813

Move Rasterizer::Draw's discard_callback to Delegate #44813

Uh oh!

Conversation

dkwingsmt commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

loic-sharma Aug 21, 2023

Choose a reason for hiding this comment

Uh oh!

loic-sharma left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dkwingsmt commented Aug 17, 2023 •

edited

Loading

loic-sharma left a comment •

edited

Loading