This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Return keyboard pressed state #43998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroux
force-pushed
the
windows_return_keyboard_pressed_state
branch
from
4adc525 to
036c58f
Compare
|
Reopening after a wrong push. |
bleroux
force-pushed
the
windows_return_keyboard_pressed_state
branch
from
7ad07f6 to
3cb7b59
Compare
dkwingsmt
reviewed
Aug 3, 2023
Comment on lines
117
to
118
| std::map<uint64_t, uint64_t> Empty_State; | ||
| return Empty_State; |
There was a problem hiding this comment.
Suggested change
| std::map<uint64_t, uint64_t> Empty_State; | |
| return Empty_State; | |
| std::map<uint64_t, uint64_t> empty_state; | |
| return empty_state; |
There was a problem hiding this comment.
Can we add some doc explaining why this function targets KeyboardKeyEmbedderHandler only so that this implementation is ok?
There was a problem hiding this comment.
I push an update to fix the variable name and to add a comment.
bleroux
force-pushed
the
windows_return_keyboard_pressed_state
branch
from
3cb7b59 to
c4ec7d4
Compare
bleroux
force-pushed
the
windows_return_keyboard_pressed_state
branch
from
c4ec7d4 to
64f1271
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 9, 2023
…132233) flutter/engine@3d3fb4f...30e7780 2023-08-09 [email protected] Roll Skia from 3e85749702f4 to 17ba2122707b (2 revisions) (flutter/engine#44540) 2023-08-09 [email protected] Roll Skia from e892c300a7c4 to 3e85749702f4 (1 revision) (flutter/engine#44539) 2023-08-09 [email protected] Roll Skia from ff6d82573f69 to e892c300a7c4 (1 revision) (flutter/engine#44538) 2023-08-09 [email protected] Roll Skia from e2885a01f134 to ff6d82573f69 (3 revisions) (flutter/engine#44536) 2023-08-09 [email protected] Remove GFX and Scenic dependencies from Fuchsia integration tests (flutter/engine#44498) 2023-08-09 [email protected] Roll Skia from ac2b25fec6eb to e2885a01f134 (1 revision) (flutter/engine#44534) 2023-08-09 [email protected] Roll Skia from d097852dc928 to ac2b25fec6eb (3 revisions) (flutter/engine#44533) 2023-08-09 [email protected] [Windows] Return keyboard pressed state (flutter/engine#43998) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
14 tasks
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
## Description This PR updates the Windows engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885). ## Related Issue Windows engine implementation for flutter/flutter#87391. Similar to: - Linux: flutter#42346 - Android: flutter#42758 - macOS: flutter#42878 ## Tests Adds 2 tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Windows engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885).
Related Issue
Windows engine implementation for flutter/flutter#87391.
Similar to:
Tests
Adds 2 tests.