This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Android] Return the keyboard pressed state #42758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroux
force-pushed
the
android_return_keyboard_pressed_state
branch
from
64e7681 to
e6d1b27
Compare
|
cc @dkwingsmt who may have context. In triage, we were wondering how this can be implemented without being inherently racy. |
|
I cherrypicked this change into the internal app that reported the issue which led to the revert #42616, and can no longer reproduce it. I don't think I'm the right person to review this PR though, so removing myself. |
|
@jiahaog Thank you so much for verifying this! |
bleroux
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 21, 2023
…129234) flutter/engine@946f523...5313ca3 2023-06-21 [email protected] Roll Fuchsia Mac SDK from fdtK_FqpscIVvbb_j... to ct6r5YjdG2xpZPhkT... (flutter/engine#43035) 2023-06-21 [email protected] [Android] Return the keyboard pressed state (flutter/engine#42758) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from fdtK_FqpscIV to ct6r5YjdG2xp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
## Description This PR updates the macOS engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885). ## Related Issue macOS engine implementation for flutter/flutter#87391 Similar to: - Linux: #42346 - Android: #42758 ## Tests Adds 2 tests.
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
## Description This PR updates the Windows engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885). ## Related Issue Windows engine implementation for flutter/flutter#87391. Similar to: - Linux: #42346 - Android: #42758 - macOS: #42878 ## Tests Adds 2 tests.
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
## Description This PR updates the macOS engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885). ## Related Issue macOS engine implementation for flutter/flutter#87391 Similar to: - Linux: flutter#42346 - Android: flutter#42758 ## Tests Adds 2 tests.
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
## Description This PR updates the Windows engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885). ## Related Issue Windows engine implementation for flutter/flutter#87391. Similar to: - Linux: flutter#42346 - Android: flutter#42758 - macOS: flutter#42878 ## Tests Adds 2 tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Android engine in order to answer to keyboard pressed state queries from the framework (as implemented in flutter/flutter#122885).
This is a rework of #41695 which was reverted in #42346.
This issue with #41695 was that the framework side did not get an answer when the channel was setup in the engine without registering a handler (on the engine side) to handle framework requests. The issue was reproducible when the engine initialization was managed by the app (see flutter/flutter#122441 (comment) for a repro).
This PR fixes this issue by changing
flutter/keyboardlifecycle: the engine now creates the channel and registers a handler just after the channel creation.In order to avoid regression, this PR also updates the channel implemenation (see
KeyboardChannel) to return an emptyHashMapwhen there is no handler registered.Related Issue
Android engine implementation for flutter/flutter#87391
(see #42346 for Linux implementation)
Fixes flutter/flutter#122441
Tests
Adds 3 tests.