This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Remove more calls to SkCanvas::flush() and SkSurface::flush()" #43957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-web
kjlubick
approved these changes
Jul 24, 2023
Contributor
|
I had landed that PR because I thought they were infra-related flakes. Happy to revert to see if it fixes things. |
Member
Author
|
Landing without waiting for all presubs to finish to try to re-open the tree |
Member
Author
|
The tree returned to green after this revert. |
Contributor
|
Thanks for the revert. I'm a bit puzzled why my change caused it, but I can dig in more. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 24, 2023
…131207) flutter/engine@aa876f6...2b8d83f 2023-07-24 [email protected] Revert "Remove more calls to SkCanvas::flush() and SkSurface::flush()" (flutter/engine#43957) 2023-07-24 [email protected] Roll Fuchsia Linux SDK from A02P1GsGg001-Mpn3... to DOxjABQZ-mA_9Lllw... (flutter/engine#43953) 2023-07-24 [email protected] Remove more calls to SkCanvas::flush() and SkSurface::flush() (flutter/engine#43902) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from A02P1GsGg001 to DOxjABQZ-mA_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#131207) flutter/engine@aa876f6...2b8d83f 2023-07-24 [email protected] Revert "Remove more calls to SkCanvas::flush() and SkSurface::flush()" (flutter/engine#43957) 2023-07-24 [email protected] Roll Fuchsia Linux SDK from A02P1GsGg001-Mpn3... to DOxjABQZ-mA_9Lllw... (flutter/engine#43953) 2023-07-24 [email protected] Remove more calls to SkCanvas::flush() and SkSurface::flush() (flutter/engine#43902) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from A02P1GsGg001 to DOxjABQZ-mA_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…lutter#131207) flutter/engine@aa876f6...2b8d83f 2023-07-24 [email protected] Revert "Remove more calls to SkCanvas::flush() and SkSurface::flush()" (flutter/engine#43957) 2023-07-24 [email protected] Roll Fuchsia Linux SDK from A02P1GsGg001-Mpn3... to DOxjABQZ-mA_9Lllw... (flutter/engine#43953) 2023-07-24 [email protected] Remove more calls to SkCanvas::flush() and SkSurface::flush() (flutter/engine#43902) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from A02P1GsGg001 to DOxjABQZ-mA_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #43902
Speculative revert for Fuchsia tests that began failing/timing-out on this commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Fuchsia%20FEMU/16871/overview