This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove more calls to SkCanvas::flush() and SkSurface::flush() #43902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-web
chinmaygarde
approved these changes
Jul 24, 2023
zanderso
added a commit
that referenced
this pull request
Jul 24, 2023
#43957) Reverts #43902 Speculative revert for Fuchsia tests that began failing/timing-out on this commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Fuchsia%20FEMU/16871/overview
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 24, 2023
…131207) flutter/engine@aa876f6...2b8d83f 2023-07-24 [email protected] Revert "Remove more calls to SkCanvas::flush() and SkSurface::flush()" (flutter/engine#43957) 2023-07-24 [email protected] Roll Fuchsia Linux SDK from A02P1GsGg001-Mpn3... to DOxjABQZ-mA_9Lllw... (flutter/engine#43953) 2023-07-24 [email protected] Remove more calls to SkCanvas::flush() and SkSurface::flush() (flutter/engine#43902) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from A02P1GsGg001 to DOxjABQZ-mA_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kjlubick
added a commit
that referenced
this pull request
Jul 25, 2023
#43965) Relanding #43902 without the copy-pasta return statements which did not seem to cause a compile issue, but caused Fuchsia tests to hang. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
psydox
pushed a commit
to psydox/skia
that referenced
this pull request
Jul 26, 2023
Client CLs: - https://crrev.com/c/4636561 - flutter/engine#43684 - flutter/engine#43902 - flutter/engine#43965 - http://ag/24023223 - http://ag/24036771 - http://cl/549054892 - http://cl/548702476 - http://cl/548179304 - http://cl/548167668 - http://cl/549996422 - http://cl/547840356 Change-Id: I657d85bf9026dabfe8c872fe31d6e4ed49a027e7 Bug: skia:14317 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/727040 Commit-Queue: Kevin Lubick <[email protected]> Reviewed-by: Brian Osman <[email protected]>
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#131207) flutter/engine@aa876f6...2b8d83f 2023-07-24 [email protected] Revert "Remove more calls to SkCanvas::flush() and SkSurface::flush()" (flutter/engine#43957) 2023-07-24 [email protected] Roll Fuchsia Linux SDK from A02P1GsGg001-Mpn3... to DOxjABQZ-mA_9Lllw... (flutter/engine#43953) 2023-07-24 [email protected] Remove more calls to SkCanvas::flush() and SkSurface::flush() (flutter/engine#43902) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from A02P1GsGg001 to DOxjABQZ-mA_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
…lutter#131207) flutter/engine@aa876f6...2b8d83f 2023-07-24 [email protected] Revert "Remove more calls to SkCanvas::flush() and SkSurface::flush()" (flutter/engine#43957) 2023-07-24 [email protected] Roll Fuchsia Linux SDK from A02P1GsGg001-Mpn3... to DOxjABQZ-mA_9Lllw... (flutter/engine#43953) 2023-07-24 [email protected] Remove more calls to SkCanvas::flush() and SkSurface::flush() (flutter/engine#43902) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from A02P1GsGg001 to DOxjABQZ-mA_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
flutter#43965) Relanding flutter#43902 without the copy-pasta return statements which did not seem to cause a compile issue, but caused Fuchsia tests to hang. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skia has removed flushing from both SkCanvas and SkSurface. This migrates the calls to use GrDirectContext directly (or removing no-op flushes for Raster canvases/surfaces).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.