This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Move linux clang tidy to engine_v2." #42434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 26afce9.
jason-simmons
approved these changes
May 30, 2023
zanderso
added
the
autosubmit
Member
|
The engine_v2 recipe is retrying the clang-tidy linter up to 3 times after it reports an error The retries for deflaking that are done for other tests should be skipped for clang-tidy. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 31, 2023
…127903) flutter/engine@dff1847...5374988 2023-05-30 [email protected] Enables bugprone-unchecked-optional-access for some files (flutter/engine#42428) 2023-05-30 [email protected] Revert "Move linux clang tidy to engine_v2." (flutter/engine#42434) 2023-05-30 [email protected] Roll Skia from fed417995ba9 to 870e249c99a7 (14 revisions) (flutter/engine#42435) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
Reverts #41985 This is also suffering some the same issue as the Linux clang-tidy shards reverted in #42434. e.g. https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20mac_clang_tidy/867/overview https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/210269/overview
godofredoc
added a commit
that referenced
this pull request
Jun 9, 2023
This reverts commit e0499f5.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #42112
Try jobs appear to be running mysteriously slow and timing out: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/922165/overview
I'm guessing that the sharding might not be working quite right.