Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

This PR moves the v2 from staging to prod and it also moves linux android | host clang tidy to staging.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This PR moves the v2 from staging to prod and it also moves linux
android | host clang tidy to staging.
@godofredoc godofredoc requested a review from zanderso May 17, 2023 23:35
zanderso
zanderso previously approved these changes May 18, 2023
@zanderso zanderso dismissed their stale review May 18, 2023 17:29

noted in comment

@zanderso
Copy link
Member

The new job on CI keeps getting cancelled.

@godofredoc
Copy link
Contributor Author

The new job on CI keeps getting cancelled.

Thanks, I'll take a look

@godofredoc
Copy link
Contributor Author

The new job on CI keeps getting cancelled.

Thanks, I'll take a look

@zanderso with the second layer cache rolled out we are ready to land this change https://ci.chromium.org/p/flutter/builders/staging/Linux%20linux_clang_tidy

@zanderso
Copy link
Member

fyi @bdero engine sheriff

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label May 25, 2023
@auto-submit auto-submit bot merged commit 26afce9 into flutter:main May 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 25, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 25, 2023
…127619)

flutter/engine@6ff02c1...99f2653

2023-05-25 [email protected] Implement Web Codecs for Skwasm (flutter/engine#42184)
2023-05-25 [email protected] Move linux clang tidy to engine_v2. (flutter/engine#42112)
2023-05-25 [email protected] Roll Skia from 69d0aa065992 to e648bf802cd2 (11 revisions) (flutter/engine#42323)
2023-05-25 [email protected] Only use 8 cores for web test compilation. (flutter/engine#42321)
2023-05-25 [email protected] Roll Fuchsia Linux SDK from nLnQzTesaABpgroOl... to DNwJQMQZladAsKTjv... (flutter/engine#42322)
2023-05-25 [email protected] Dynamically link against system fontconfig (flutter/engine#40725)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from nLnQzTesaABp to DNwJQMQZladA

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@godofredoc godofredoc deleted the move_clang_tidy branch May 26, 2023 00:11
zanderso added a commit that referenced this pull request May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants