This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix upload xcresult script in run_tests.py #42056
Merged
auto-submit
merged 3 commits into
flutter:main
from
cyanglaz:upload_xcresult_unittest_fix
May 15, 2023
Merged
Fix upload xcresult script in run_tests.py #42056
auto-submit
merged 3 commits into
flutter:main
from
cyanglaz:upload_xcresult_unittest_fix
May 15, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
May 15, 2023
Contributor
Author
|
Test PR is here: #41929 |
Contributor
|
auto label is removed for flutter/engine, pr: 42056, Failed to merge flutter/engine/42056 with Pull request could not be merged: Pull Request is still a draft. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 16, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 16, 2023
…126894) flutter/engine@027ca79...c4d4b40 2023-05-15 [email protected] Fix upload xcresult script in run_tests.py (flutter/engine#42056) 2023-05-15 [email protected] [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054) 2023-05-15 [email protected] Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058) 2023-05-15 [email protected] Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057) 2023-05-15 [email protected] [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055) 2023-05-15 [email protected] Compile skwasm at -Oz. (flutter/engine#42002) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…lutter#126894) flutter/engine@027ca79...c4d4b40 2023-05-15 [email protected] Fix upload xcresult script in run_tests.py (flutter/engine#42056) 2023-05-15 [email protected] [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054) 2023-05-15 [email protected] Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058) 2023-05-15 [email protected] Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057) 2023-05-15 [email protected] [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055) 2023-05-15 [email protected] Compile skwasm at -Oz. (flutter/engine#42002) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR #41647 forgot to add try-except-raise
fixes flutter/flutter#125823
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.