Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@cyanglaz
Copy link
Contributor

The original PR #41647 forgot to add try-except-raise

fixes flutter/flutter#125823

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz requested a review from gaaclarke May 15, 2023 20:59
@cyanglaz
Copy link
Contributor Author

Test PR is here: #41929

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 15, 2023

auto label is removed for flutter/engine, pr: 42056, Failed to merge flutter/engine/42056 with Pull request could not be merged: Pull Request is still a draft.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023
@cyanglaz cyanglaz marked this pull request as ready for review May 15, 2023 22:28
@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023
@auto-submit auto-submit bot merged commit c4d4b40 into flutter:main May 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 16, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 16, 2023
…126894)

flutter/engine@027ca79...c4d4b40

2023-05-15 [email protected] Fix upload xcresult script in run_tests.py (flutter/engine#42056)
2023-05-15 [email protected] [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054)
2023-05-15 [email protected] Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058)
2023-05-15 [email protected] Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057)
2023-05-15 [email protected] [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055)
2023-05-15 [email protected] Compile skwasm at -Oz. (flutter/engine#42002)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…lutter#126894)

flutter/engine@027ca79...c4d4b40

2023-05-15 [email protected] Fix upload xcresult script in run_tests.py (flutter/engine#42056)
2023-05-15 [email protected] [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054)
2023-05-15 [email protected] Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058)
2023-05-15 [email protected] Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057)
2023-05-15 [email protected] [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055)
2023-05-15 [email protected] Compile skwasm at -Oz. (flutter/engine#42002)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zip and upload xcresults on failing engine iOS native tests in LUCI

2 participants