[Impeller] set stencil attachment descriptor for runtime effect. #42054
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| desc.SetStencilAttachmentDescriptors({}); | ||
|
|
||
| StencilAttachmentDescriptor stencil0; | ||
| stencil0.stencil_compare = CompareFunction::kEqual; |
There was a problem hiding this comment.
The stencil depth (you can get this from the Entity) should also be set here, otherwise any clips will cause the output to get discarded.
There was a problem hiding this comment.
Specifically, the "stencil_reference" field.
There was a problem hiding this comment.
We also set this on the command below. its a bit hard to track though, I think ultimately all of this information needs to end up on the descriptor right?
There was a problem hiding this comment.
Ah whoops, I missed that we're already setting it.
The reason we have the stencil ref on the command and not the pipeline descriptor is that it's a pipeline input, not a property that we need to hash and build new pipelines for.
| desc.SetStencilAttachmentDescriptors({}); | ||
|
|
||
| StencilAttachmentDescriptor stencil0; | ||
| stencil0.stencil_compare = CompareFunction::kEqual; |
There was a problem hiding this comment.
Ah whoops, I missed that we're already setting it.
The reason we have the stencil ref on the command and not the pipeline descriptor is that it's a pipeline input, not a property that we need to hash and build new pipelines for.
|
test added, waiting for gold results |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jonahwilliams
added
the
autosubmit
…126894) flutter/engine@027ca79...c4d4b40 2023-05-15 [email protected] Fix upload xcresult script in run_tests.py (flutter/engine#42056) 2023-05-15 [email protected] [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054) 2023-05-15 [email protected] Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058) 2023-05-15 [email protected] Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057) 2023-05-15 [email protected] [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055) 2023-05-15 [email protected] Compile skwasm at -Oz. (flutter/engine#42002) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Can we cherry pick this please? The issue template for requesting the cherry pick is here. |
…lutter#126894) flutter/engine@027ca79...c4d4b40 2023-05-15 [email protected] Fix upload xcresult script in run_tests.py (flutter/engine#42056) 2023-05-15 [email protected] [Impeller] set stencil attachment descriptor for runtime effect. (flutter/engine#42054) 2023-05-15 [email protected] Roll Skia from 4becb53e3c21 to 24bebce2d9a1 (20 revisions) (flutter/engine#42058) 2023-05-15 [email protected] Roll Fuchsia Linux SDK from EweLgJoiYUDok2vyU... to 38Oyy28qgYCdt7fEV... (flutter/engine#42057) 2023-05-15 [email protected] [Impeller] Remove debug print statement from EntityPass (flutter/engine#42055) 2023-05-15 [email protected] Compile skwasm at -Oz. (flutter/engine#42002) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from EweLgJoiYUDo to 38Oyy28qgYCd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
This fixes the correctness issues observed in flutter/flutter#126701 . The missing stencil descriptor meant that the clips were always ignored.
Have not yet investigated the reported debug performance issues.