Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@godofredoc
Copy link
Contributor

This builder run android and host clang tidy in an engine v2 build.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc requested a review from zanderso May 13, 2023 03:06
@godofredoc
Copy link
Contributor Author

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit auto-submit bot merged commit 5cf141f into flutter:main May 16, 2023
@godofredoc godofredoc deleted the linux_host_cland_tody branch May 16, 2023 16:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 16, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 16, 2023
…126934)

flutter/engine@fe24767...5cf141f

2023-05-16 [email protected] Add linux_clang_tidy builder. (flutter/engine#41990)
2023-05-16 [email protected] [ios_platform_view] only recycle maskView when the view is applying mutators (flutter/engine#41573)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 16, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request May 16, 2023
…sions) (#126961)

Manual roll requested by [email protected]

flutter/engine@fe24767...1c775e3

2023-05-16 [email protected] Revert "[ios_platform_view]
only recycle maskView when the view is applying mutators"
(flutter/engine#42080)
2023-05-16 [email protected] [macOS] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41753)
2023-05-16 [email protected] [linux] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41782)
2023-05-16 [email protected] Initial support for images in
Skwasm (flutter/engine#42019)
2023-05-16 [email protected] Use new `unresolvedCodePoints` API
from skia. (flutter/engine#41991)
2023-05-16 [email protected] Convert public API
NativeFieldWrapper classes to abstract interfaces (flutter/engine#41945)
2023-05-16 [email protected] [Windows] Add
force redraw to the C++ client wrapper (flutter/engine#42061)
2023-05-16 [email protected] Fix drone_dimension
host_engine_builder. (flutter/engine#42068)
2023-05-16 [email protected] Add linux_clang_tidy builder.
(flutter/engine#41990)
2023-05-16 [email protected] [ios_platform_view] only recycle maskView
when the view is applying mutators (flutter/engine#41573)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…lutter#126934)

flutter/engine@fe24767...5cf141f

2023-05-16 [email protected] Add linux_clang_tidy builder. (flutter/engine#41990)
2023-05-16 [email protected] [ios_platform_view] only recycle maskView when the view is applying mutators (flutter/engine#41573)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
…sions) (flutter#126961)

Manual roll requested by [email protected]

flutter/engine@fe24767...1c775e3

2023-05-16 [email protected] Revert "[ios_platform_view]
only recycle maskView when the view is applying mutators"
(flutter/engine#42080)
2023-05-16 [email protected] [macOS] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41753)
2023-05-16 [email protected] [linux] Wait for
binding to be ready before requesting exits from framework
(flutter/engine#41782)
2023-05-16 [email protected] Initial support for images in
Skwasm (flutter/engine#42019)
2023-05-16 [email protected] Use new `unresolvedCodePoints` API
from skia. (flutter/engine#41991)
2023-05-16 [email protected] Convert public API
NativeFieldWrapper classes to abstract interfaces (flutter/engine#41945)
2023-05-16 [email protected] [Windows] Add
force redraw to the C++ client wrapper (flutter/engine#42061)
2023-05-16 [email protected] Fix drone_dimension
host_engine_builder. (flutter/engine#42068)
2023-05-16 [email protected] Add linux_clang_tidy builder.
(flutter/engine#41990)
2023-05-16 [email protected] [ios_platform_view] only recycle maskView
when the view is applying mutators (flutter/engine#41573)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that
a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants