This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Convert public API NativeFieldWrapper classes to abstract interfaces #41945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
May 11, 2023
lib/ui/compositing.dart
Outdated
| return true; | ||
| } | ||
| abstract class SceneBuilder { | ||
| factory SceneBuilder() => _NativeSceneBuilder(); |
Contributor
There was a problem hiding this comment.
Here and elsewhere - should this be a redirecting factory instead, i.e.
Suggested change
| factory SceneBuilder() => _NativeSceneBuilder(); | |
| factory SceneBuilder() = _NativeSceneBuilder; |
dnfield
approved these changes
May 11, 2023
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM once the downstream flutter/flutter#126570 lands - there's one other issue in CI about marking one of the Shader subclasses as base too
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 16, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 16, 2023
…sions) (#126961) Manual roll requested by [email protected] flutter/engine@fe24767...1c775e3 2023-05-16 [email protected] Revert "[ios_platform_view] only recycle maskView when the view is applying mutators" (flutter/engine#42080) 2023-05-16 [email protected] [macOS] Wait for binding to be ready before requesting exits from framework (flutter/engine#41753) 2023-05-16 [email protected] [linux] Wait for binding to be ready before requesting exits from framework (flutter/engine#41782) 2023-05-16 [email protected] Initial support for images in Skwasm (flutter/engine#42019) 2023-05-16 [email protected] Use new `unresolvedCodePoints` API from skia. (flutter/engine#41991) 2023-05-16 [email protected] Convert public API NativeFieldWrapper classes to abstract interfaces (flutter/engine#41945) 2023-05-16 [email protected] [Windows] Add force redraw to the C++ client wrapper (flutter/engine#42061) 2023-05-16 [email protected] Fix drone_dimension host_engine_builder. (flutter/engine#42068) 2023-05-16 [email protected] Add linux_clang_tidy builder. (flutter/engine#41990) 2023-05-16 [email protected] [ios_platform_view] only recycle maskView when the view is applying mutators (flutter/engine#41573) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…sions) (flutter#126961) Manual roll requested by [email protected] flutter/engine@fe24767...1c775e3 2023-05-16 [email protected] Revert "[ios_platform_view] only recycle maskView when the view is applying mutators" (flutter/engine#42080) 2023-05-16 [email protected] [macOS] Wait for binding to be ready before requesting exits from framework (flutter/engine#41753) 2023-05-16 [email protected] [linux] Wait for binding to be ready before requesting exits from framework (flutter/engine#41782) 2023-05-16 [email protected] Initial support for images in Skwasm (flutter/engine#42019) 2023-05-16 [email protected] Use new `unresolvedCodePoints` API from skia. (flutter/engine#41991) 2023-05-16 [email protected] Convert public API NativeFieldWrapper classes to abstract interfaces (flutter/engine#41945) 2023-05-16 [email protected] [Windows] Add force redraw to the C++ client wrapper (flutter/engine#42061) 2023-05-16 [email protected] Fix drone_dimension host_engine_builder. (flutter/engine#42068) 2023-05-16 [email protected] Add linux_clang_tidy builder. (flutter/engine#41990) 2023-05-16 [email protected] [ios_platform_view] only recycle maskView when the view is applying mutators (flutter/engine#41573) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See flutter/flutter#123756