Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ci/licenses_golden/licenses_flutter
Original file line number Diff line number Diff line change
Expand Up @@ -2791,7 +2791,6 @@ ORIGIN: ../../../flutter/shell/platform/fuchsia/dart_runner/dart_runner.h + ../.
ORIGIN: ../../../flutter/shell/platform/fuchsia/dart_runner/dart_test_component_controller.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/dart_runner/dart_test_component_controller.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/dart_runner/embedder/builtin.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/dart_runner/embedder/script_runner_snapshot.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/dart_runner/embedder/shim.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/dart_runner/embedder/snapshot.cc.tmpl + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/shell/platform/fuchsia/dart_runner/embedder/snapshot.dart + ../../../flutter/LICENSE
Expand Down Expand Up @@ -5406,7 +5405,6 @@ FILE: ../../../flutter/shell/platform/fuchsia/dart_runner/dart_runner.h
FILE: ../../../flutter/shell/platform/fuchsia/dart_runner/dart_test_component_controller.cc
FILE: ../../../flutter/shell/platform/fuchsia/dart_runner/dart_test_component_controller.h
FILE: ../../../flutter/shell/platform/fuchsia/dart_runner/embedder/builtin.dart
FILE: ../../../flutter/shell/platform/fuchsia/dart_runner/embedder/script_runner_snapshot.dart
FILE: ../../../flutter/shell/platform/fuchsia/dart_runner/embedder/shim.dart
FILE: ../../../flutter/shell/platform/fuchsia/dart_runner/embedder/snapshot.cc.tmpl
FILE: ../../../flutter/shell/platform/fuchsia/dart_runner/embedder/snapshot.dart
Expand Down

This file was deleted.

5 changes: 3 additions & 2 deletions shell/platform/fuchsia/flutter/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,10 @@ template("runner_sources") {
"$fuchsia_sdk_root/fidl:fuchsia.ui.app",
"$fuchsia_sdk_root/fidl:fuchsia.ui.composition",
"$fuchsia_sdk_root/fidl:fuchsia.ui.pointer",
"$fuchsia_sdk_root/fidl:fuchsia.ui.views",
"$fuchsia_sdk_root/fidl:fuchsia.ui.scenic",
"$fuchsia_sdk_root/fidl:fuchsia.ui.pointerinjector",
"$fuchsia_sdk_root/fidl:fuchsia.ui.scenic",
"$fuchsia_sdk_root/fidl:fuchsia.ui.test.input",
"$fuchsia_sdk_root/fidl:fuchsia.ui.views",
"$fuchsia_sdk_root/pkg:async-cpp",
"$fuchsia_sdk_root/pkg:async-default",
"$fuchsia_sdk_root/pkg:async-loop",
Expand Down
8 changes: 5 additions & 3 deletions shell/platform/fuchsia/flutter/engine.cc
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ void Engine::Initialize(
session_connection_->AwaitVsyncForSecondaryCallback(cb);
}
},
product_config](flutter::Shell& shell) mutable {
product_config, svc](flutter::Shell& shell) mutable {
OnShaderWarmup on_shader_warmup = nullptr;
if (product_config.enable_shader_warmup()) {
FML_DCHECK(surface_producer_);
Expand Down Expand Up @@ -636,7 +636,8 @@ void Engine::Initialize(
std::move(on_request_announce_callback),
std::move(on_shader_warmup),
std::move(await_vsync_callback),
std::move(await_vsync_for_secondary_callback_callback));
std::move(await_vsync_for_secondary_callback_callback),
std::move(svc));
} else {
platform_view = std::make_unique<flutter_runner::GfxPlatformView>(
shell, shell.GetTaskRunners(), std::move(view_ref),
Expand All @@ -655,7 +656,8 @@ void Engine::Initialize(
std::move(on_semantics_node_update_callback),
std::move(on_request_announce_callback),
std::move(on_shader_warmup), std::move(await_vsync_callback),
std::move(await_vsync_for_secondary_callback_callback));
std::move(await_vsync_for_secondary_callback_callback),
std::move(svc));
}
return platform_view;
});
Expand Down
6 changes: 4 additions & 2 deletions shell/platform/fuchsia/flutter/flatland_platform_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ FlatlandPlatformView::FlatlandPlatformView(
OnShaderWarmup on_shader_warmup,
AwaitVsyncCallback await_vsync_callback,
AwaitVsyncForSecondaryCallbackCallback
await_vsync_for_secondary_callback_callback)
await_vsync_for_secondary_callback_callback,
std::shared_ptr<sys::ServiceDirectory> dart_application_svc)
: PlatformView(true /* is_flatland */,
delegate,
std::move(task_runners),
Expand All @@ -52,7 +53,8 @@ FlatlandPlatformView::FlatlandPlatformView(
std::move(on_request_announce_callback),
std::move(on_shader_warmup),
std::move(await_vsync_callback),
std::move(await_vsync_for_secondary_callback_callback)),
std::move(await_vsync_for_secondary_callback_callback),
std::move(dart_application_svc)),
parent_viewport_watcher_(parent_viewport_watcher.Bind()),
on_create_view_callback_(std::move(on_create_view_callback)),
on_destroy_view_callback_(std::move(on_destroy_view_callback)),
Expand Down
3 changes: 2 additions & 1 deletion shell/platform/fuchsia/flutter/flatland_platform_view.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ class FlatlandPlatformView final : public flutter_runner::PlatformView {
OnShaderWarmup on_shader_warmup,
AwaitVsyncCallback await_vsync_callback,
AwaitVsyncForSecondaryCallbackCallback
await_vsync_for_secondary_callback_callback);
await_vsync_for_secondary_callback_callback,
std::shared_ptr<sys::ServiceDirectory> dart_application_svc);
~FlatlandPlatformView() override;

void OnGetLayout(fuchsia::ui::composition::LayoutInfo info);
Expand Down
6 changes: 4 additions & 2 deletions shell/platform/fuchsia/flutter/gfx_platform_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ GfxPlatformView::GfxPlatformView(
OnShaderWarmup on_shader_warmup,
AwaitVsyncCallback await_vsync_callback,
AwaitVsyncForSecondaryCallbackCallback
await_vsync_for_secondary_callback_callback)
await_vsync_for_secondary_callback_callback,
std::shared_ptr<sys::ServiceDirectory> dart_application_svc)
: PlatformView(false /* is_flatland */,
delegate,
std::move(task_runners),
Expand All @@ -53,7 +54,8 @@ GfxPlatformView::GfxPlatformView(
std::move(on_request_announce_callback),
std::move(on_shader_warmup),
std::move(await_vsync_callback),
std::move(await_vsync_for_secondary_callback_callback)),
std::move(await_vsync_for_secondary_callback_callback),
std::move(dart_application_svc)),
session_listener_binding_(this, std::move(session_listener_request)),
session_listener_error_callback_(
std::move(on_session_listener_error_callback)),
Expand Down
3 changes: 2 additions & 1 deletion shell/platform/fuchsia/flutter/gfx_platform_view.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ class GfxPlatformView final : public flutter_runner::PlatformView,
OnShaderWarmup on_shader_warmup,
AwaitVsyncCallback await_vsync_callback,
AwaitVsyncForSecondaryCallbackCallback
await_vsync_for_secondary_callback_callback);
await_vsync_for_secondary_callback_callback,
std::shared_ptr<sys::ServiceDirectory> dart_application_svc);

~GfxPlatformView() override;

Expand Down
Loading