This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Stop calling FIDL from Dart in Flutter integration tests #41669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the `fx serve` check to reflect the current state of Fuchsia's package serving.
As we move the Dart FIDL bindings we need to stop calling FIDL methods from Dart in the Flutter repo. This only affects some integration tests. This moves the FIDL calls into C++ and uses platform messages to make the functionality available to the Dart tests.
arbreng
approved these changes
May 3, 2023
| return false; | ||
| } | ||
|
|
||
| FML_LOG(INFO) << "fuchsia/input_test: method=" << method->value.GetString(); |
Contributor
There was a problem hiding this comment.
Remove or make a verbose log
| import 'dart:ui'; | ||
|
|
||
| import 'package:args/args.dart'; | ||
| import 'package:fidl_fuchsia_ui_app/fidl_async.dart'; |
Contributor
There was a problem hiding this comment.
How are you going to handle "fuchsia.ui.app" and "fuchsia.ui.views"?
I think we could do:
- "_launchGfxChildView" connects to the incoming ViewProvider service, so it can be made into a platform message.
- The ViewHolderToken and ViewRef/ViewRefControl types can all be encoded as integers in the platform message (cast the zx_handle_t to an integer). This is already what we do for the "View.create" message on the platform views channel so there is precedent. When the associated dart EventPair/etc objects die, they will call zx_handle_close but then ignore the error that gets returned.
Contributor
Author
There was a problem hiding this comment.
I'm going to update this PR with those changes too. Basically I expose a native function over platform messages that mints a child view (either gfx or flatland based on an argument) and returns the view id as an integer.
This addresses some earlier comments plus removes fuchsia.ui.app and fuchsia.ui.views.
ianloic
changed the title
ianloic
changed the title
arbreng
approved these changes
May 5, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 9, 2023
…126309) flutter/engine@8d3a816...824cd09 2023-05-09 [email protected] Increase timeout of orchestrator. (flutter/engine#41839) 2023-05-09 [email protected] [fuchsia] Stop calling FIDL from Dart in Flutter integration tests (flutter/engine#41669) 2023-05-09 [email protected] [tests] Remove unused fuchsia.sys protocol reference (flutter/engine#41826) 2023-05-09 [email protected] Roll Skia from 7736fbaf84f0 to 485cd3d0f9ca (6 revisions) (flutter/engine#41840) 2023-05-09 [email protected] [Impeller] introduces DeviceHolder to avoid accessing a dead Device (flutter/engine#41748) 2023-05-08 [email protected] Get rid of "outrageous" default text styles for HTML renderer. (flutter/engine#41822) 2023-05-08 [email protected] Adjust DL filter bounds tests to not rely on exact Skia results (flutter/engine#41792) 2023-05-08 [email protected] Roll Dart SDK from a8b6687327d6 to 498cfa57165b (1 revision) (flutter/engine#41823) 2023-05-08 [email protected] [Android] Fix incorrect viewInsets during keyboard animation with EdgeToEdge (flutter/engine#39391) 2023-05-08 [email protected] Roll Skia from 951eb9653163 to 7736fbaf84f0 (1 revision) (flutter/engine#41821) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we move the Dart FIDL bindings we need to stop calling FIDL methods
from Dart in the Flutter repo. This only affects some integration tests.
This moves the FIDL calls into C++ and uses platform messages to make
the functionality available to the Dart tests.