-
Notifications
You must be signed in to change notification settings - Fork 6k
Revert "Add support for double tap action from Apple Pencil 2" #41138
Revert "Add support for double tap action from Apple Pencil 2" #41138
Conversation
…ehsu/pencil-double-tap
hellohuanlin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for cleaning this up!
|
#39637 is included in the 3.10 beta. Does this revert need to be CP'd to the release branch? |
I don't think so, |
|
@LouiseHsu did you land the framework or engine change first? When reverting, it's probably safer to do the opposite order. (I'm a bit lost in the "revert of revert" in one of your PR, but I can help to look into if you don't remember either) |
I think the only framework change that made it in was flutter/flutter#120731 which wouldn't need to be reverted in any particular order. |
…er#41138) Reverts flutter#39637 Since this feature flutter/flutter#73172 has been scrapped for now, previous engine work should be reverted. Refer to [this design doc](https://docs.google.com/document/d/1r4P5r-jGt2Sjqro3ldCU2axUiHTpu3yhIycnI94OKQw/edit ) for more discussion and details.
Reverts #39637
Since this feature flutter/flutter#73172 has been scrapped for now, previous engine work should be reverted. Refer to this design doc for more discussion and details.