Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@LouiseHsu
Copy link
Contributor

Reverts #39637

Since this feature flutter/flutter#73172 has been scrapped for now, previous engine work should be reverted. Refer to this design doc for more discussion and details.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API platform-android platform-ios platform-web Code specifically for the web engine labels Apr 12, 2023
@gmackall gmackall requested a review from camsim99 April 13, 2023 18:37
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for cleaning this up!

@LouiseHsu LouiseHsu merged commit ce7be00 into main Apr 13, 2023
@LouiseHsu LouiseHsu deleted the revert-39637-revert-39607-revert-39267-louisehsu/pencil-double-tap branch April 13, 2023 21:59
@zanderso
Copy link
Member

#39637 is included in the 3.10 beta. Does this revert need to be CP'd to the release branch?

@jmagman
Copy link
Member

jmagman commented Apr 13, 2023

#39637 is included in the 3.10 beta. Does this revert need to be CP'd to the release branch?

I don't think so, preferredStylusAuxiliaryAction was never hooked up to anything in the framework, so it's unused in the engine but it's not hurting anything. @LouiseHsu @hellohuanlin can check me if I'm missing something though.

@hellohuanlin
Copy link
Contributor

@LouiseHsu did you land the framework or engine change first? When reverting, it's probably safer to do the opposite order. (I'm a bit lost in the "revert of revert" in one of your PR, but I can help to look into if you don't remember either)

@jmagman
Copy link
Member

jmagman commented Apr 13, 2023

@LouiseHsu did you land the framework or engine change first? When reverting, it's probably safer to do the opposite order. (I'm a bit lost in the "revert of revert" in one of your PR, but I can help to look into if you don't remember either)

I think the only framework change that made it in was flutter/flutter#120731 which wouldn't need to be reverted in any particular order.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 13, 2023
zhongwuzw pushed a commit to zhongwuzw/engine that referenced this pull request Apr 14, 2023
…er#41138)

Reverts flutter#39637

Since this feature flutter/flutter#73172 has
been scrapped for now, previous engine work should be reverted. Refer to
[this design
doc](https://docs.google.com/document/d/1r4P5r-jGt2Sjqro3ldCU2axUiHTpu3yhIycnI94OKQw/edit
) for more discussion and details.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

embedder Related to the embedder API platform-android platform-ios platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants