Add support for double tap action from Apple Pencil 2 #39267

LouiseHsu · 2023-01-30T22:50:18Z

This PR adds engine support for the double tap action on the Apple Pencil 2.

The Apple Pencil 2 has a feature which allows the user to double tap the side of the pencil to perform one of 4 preset actions, which can be set in Settings. The double tap is treated as a pointer event, with a new field that represents the preferred action of the user.

Framework PR will come after this is merged and will be linked here :)

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the [CLA].
All existing and new tests are passing.

hellohuanlin

Overall looks good! just some questions around the naming

hellohuanlin · 2023-01-30T23:02:49Z

lib/ui/platform_dispatcher.dart

        panDeltaY: packet.getFloat64(kStride * offset++, _kFakeHostEndian),
        scale: packet.getFloat64(kStride * offset++, _kFakeHostEndian),
        rotation: packet.getFloat64(kStride * offset++, _kFakeHostEndian),
+        preferredAction: PointerPreferredAction.values[packet.getInt64(kStride * offset++, _kFakeHostEndian)],


it's not clear what "preferredAction" or PointerPreferredAction means in this context. How about preferredStylusAuxilliaryAction and PointerPreferredStylusAuxilliaryAction

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8790504096978029009/+/u/test:_Host_Tests_for_host_debug_unopt/stdout

�[0;32m[ RUN ] �[mShellTest.CanCorrectlySynthesizePointerPacket [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: RangeError (index): Invalid value: Not in inclusive range 0..3: 1731047719413088311 #0 _Array.[] (dart:core-patch/array.dart:10:36) #1 PlatformDispatcher._unpackPointerDataPacket (dart:ui/platform_dispatcher.dart:420:55) #2 PlatformDispatcher._dispatchPointerDataPacket (dart:ui/platform_dispatcher.dart:364:9) #3 _dispatchPointerDataPacket (dart:ui/hooks.dart:91:31)

I think its actually really confusing if both the actual event and the preferredAction are called PointerPreferredStylusAuxilliaryAction and PointerStylusAuxilliaryAction respectively, I got confused just now between the two as Im trying to change the names because then the only difference them is the "preferred", and its pretty verbose

How about StylusSecondaryGesture (double tap) + ConfiguredStylusAction (the preferred action)?

hellohuanlin · 2023-01-30T23:03:20Z

lib/ui/pointer.dart

  scale,

+  /// A stylus generated action (e.g. double tap on Apple Pencil 2)
+  stylusAction,


same comment on the naming here.

lib/ui/pointer.dart

hellohuanlin · 2023-01-30T23:06:22Z

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

    case UITouchTypeIndirect:
      return flutter::PointerData::DeviceKind::kTouch;
-    case UITouchTypeStylus:
+    case UITouchTypePencil:


is this change intended?

Yeah, UITouchTypeStylus is deprecated and is suggested https://developer.apple.com/documentation/uikit/uitouchtype/uitouchtypestylus

hellohuanlin · 2023-01-30T23:07:22Z

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

+#pragma clang diagnostic push
+
+- (void)pencilInteractionDidTap:(UIPencilInteraction*)interaction API_AVAILABLE(ios(13.4)) {
+  flutter::PointerData pointer_data = [self generatePointerDataAtLastMouseLocation];


do we need the mouse location for this pointer_data?

looks like this is not resolved - we don't need the mouse location here. Can probably just do

flutter::PointerData pointer_data; pointer_data.Clear();

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm

jmagman

I know you have work-in-progress design doc out for this feature: https://docs.google.com/document/d/1r4P5r-jGt2Sjqro3ldCU2axUiHTpu3yhIycnI94OKQw/edit

I think you should finish that up, add the missing sections, and pass it around to the framework team before this gets merged.

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm

jmagman · 2023-01-30T23:52:49Z

lib/ui/pointer.dart

    this.panDeltaY = 0.0,
    this.scale = 0.0,
    this.rotation = 0.0,
+    this.preferredAction = PointerPreferredAction.ignore,


Warning: lib/ui/ui.dart PointerData.Unnamed Constructor has a different parameter length than in lib/web_ui/ui.dart.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8790504096880865457/+/u/analyze_dart_ui/stdout

This path "lib/web_ui/ui.dart" doesnt exist, but I think this is because I need to update pointer packet on the Android side too

One is udner flutter/lib/ui/pointer.dart, another one is under flutter/lib/web_ui/pointer.dart

lib/ui/pointer.dart

jmagman · 2023-01-30T23:53:26Z

lib/ui/pointer.dart

 }

+  /// The preferred action for stylus action
+enum PointerPreferredAction {


Should this specify stylus then?

Suggested change

enum PointerPreferredAction {

enum PointerPreferredStylusAction {

@hellohuanlin suggested preferredStylusAuxilliaryAction or PointerPreferredStylusAuxilliaryAction, what do you think?

I think you have an extra "l" in "Auxiliary". But what does "Auxiliary" mean in this context?

I view stylus touching on screen as the "primary action" and Apple Pencil double tap as "auxiliary action". If we just call it "stylus action" or "pointer action", it sounds like stylus touching on screen (rather finger tapping on pencil in our case)

This would be a good question for the framework team, I'm sure they have prior art for this problem.

jmagman · 2023-02-06T22:49:04Z

shell/platform/darwin/ios/framework/Source/FlutterViewController.mm


+#pragma mark - Stylus Events
+
+#pragma clang diagnostic push


Is this pragma push pop here for something? Can it be removed?

jmagman · 2023-02-06T22:50:31Z

shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm

+  if (@available(iOS 13.4, *)) {
+    // noop
+  } else {
+    return;
+  }


I don't think you need this with the API_AVAILABLE in the method signature.

This section is in every other test in this file too, they also all have the API_AVAILABLE in the signature. should I remove it for the others too?

Yes, that would be great, assuming they all pass. Thank you!

jmagman · 2023-02-06T22:51:06Z

shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm

+  XCTAssertNotNil(vc);
+
+  id mockPencilInteraction = OCMClassMock([UIPencilInteraction class]);
+  XCTAssertNotNil(mockPencilInteraction);


You don't need to assert that the mock you just made isn't nil, then you're just testing that OCMock works.

jmagman · 2023-02-06T22:51:40Z

shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm

+  pointer_data.kind = flutter::PointerData::DeviceKind::kStylus;
+  pointer_data.signal_kind = flutter::PointerData::SignalKind::kStylusAuxiliaryAction;
+  pointer_data.preferred_auxiliary_stylus_action =
+      flutter::PointerData::PreferredStylusAuxiliaryAction::kIgnore;


Where was ignore mocked?

Ignore is the default value of UIPencilInteraction.preferredAction - it's a readonly property so I'm not sure how I would mock it to be a different enum.

You can look into how to mock static methods using ocmock.

Ignore is the default value of UIPencilInteraction.preferredAction

We wouldn't want this test to fail based on real settings on the target device.

See https://ocmock.org/reference/#mocking-class-methods
It would be something like:

OCMStub([mockPencilInteraction preferredAction]).andReturn(UIPencilPreferredActionIgnore);

And at the end of the test, reset the class method mock:

[mockPencilInteraction stopMocking];

jmagman · 2023-02-07T19:25:47Z

lib/ui/pointer.dart

             'rotation: $rotation'
+             'preferredStylusAuxiliaryAction: $preferredStylusAuxiliaryAction, '


This is malformed.

Suggested change

'rotation: $rotation'

'preferredStylusAuxiliaryAction: $preferredStylusAuxiliaryAction, '

'rotation: $rotation, '

'preferredStylusAuxiliaryAction: $preferredStylusAuxiliaryAction'

jmagman · 2023-02-07T19:26:43Z

lib/web_ui/lib/pointer.dart

           'rotation: $rotation'
+           'preferredStylusAuxiliaryAction: $preferredStylusAuxiliaryAction, '


Suggested change

'rotation: $rotation'

'preferredStylusAuxiliaryAction: $preferredStylusAuxiliaryAction, '

'rotation: $rotation, '

'preferredStylusAuxiliaryAction: $preferredStylusAuxiliaryAction'

jmagman · 2023-02-07T21:27:08Z

shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm

+  auto packet = std::make_unique<flutter::PointerDataPacket>(1);
+  packet->SetPointerData(/*index=*/0, pointer_data);
+
+  [[[self.mockEngine verify] ignoringNonObjectArgs] dispatchPointerDataPacket:std::move(packet)];


ignoringNonObjectArgs is ignoring the value of the packet and accepting anything, so you aren't actually testing anything here except that dispatchPointerDataPacket was called at least once. When I swap the action to kSwitchEraser it still passes.

This doesn't pass but something like:

id mockPencilInteraction = OCMClassMock([UIPencilInteraction class]); OCMStub([mockPencilInteraction preferredTapAction]) .andReturn(UIPencilPreferredActionShowColorPalette); XCTestExpectation* pointerDataPacketExpectation = [self expectationWithDescription:@"pointerDataPacket"]; OCMStub( [self.mockEngine dispatchPointerDataPacket:std::make_unique<flutter::PointerDataPacket>(0)]) .ignoringNonObjectArgs() .andDo(^(NSInvocation* invocation) { flutter::PointerData packet; [invocation getArgument:&packet atIndex:2]; XCTAssertEqual(packet.kind, flutter::PointerData::DeviceKind::kStylus); XCTAssertEqual(packet.signal_kind, flutter::PointerData::SignalKind::kStylusAuxiliaryAction); XCTAssertEqual(packet.preferred_auxiliary_stylus_action, flutter::PointerData::PreferredStylusAuxiliaryAction::kShowColorPalette); [pointerDataPacketExpectation fulfill]; }); [vc pencilInteractionDidTap:mockPencilInteraction]; [self waitForExpectationsWithTimeout:1 handler:nil]; [mockPencilInteraction stopMocking];

Hm, this still doesn't pass but it's closer, it needs to get the pointer data off the packet.

std::unique_ptr<flutter::PointerDataPacket> packet; [invocation getArgument:&packet atIndex:2]; flutter::PointerData pointer_data = packet->GetPointerData(0); XCTAssertEqual(pointer_data.kind, flutter::PointerData::DeviceKind::kStylus); XCTAssertEqual(pointer_data.signal_kind, flutter::PointerData::SignalKind::kStylusAuxiliaryAction); XCTAssertEqual(pointer_data.preferred_auxiliary_stylus_action, flutter::PointerData::PreferredStylusAuxiliaryAction::kShowColorPalette); [pointerDataPacketExpectation fulfill];

I did some research just now - it looks like there's no such OCMock/NSInvocation API for dereferencing smart pointers at all. I think it only supports dereferencing raw pointers.

I could be wrong, but I wasn't able to find any examples online. If that's the case, verify maybe the only choice here for this test.

Another idea is to break out the main logic into a helper function like getAxiliaryActionPacket() so it's easier to test.

I could be wrong, but I wasn't able to find any examples online. If that's the case, verify maybe the only choice here for this test.

How do you suggest getting verify working? It would need to do some equality check.

I was suggesting to just verify that it is called (like this).

For the equality check, i think we can factor out a helper function getAxiliaryActionPacket() and test that instead.

jmagman · 2023-02-07T21:37:54Z

@camsim99 would you mind taking a look at the Android java part of this PR?

camsim99

Android part looks good to me!

jmagman · 2023-02-09T22:24:26Z

lib/ui/pointer.dart

             'panDeltaX: $panDeltaX, '
             'panDeltaY: $panDeltaY, '
             'scale: $scale, '
             'rotation: $rotation'


Suggested change

'rotation: $rotation'

'rotation: $rotation, '

jmagman · 2023-02-09T22:24:49Z

lib/web_ui/lib/pointer.dart

           'panDeltaX: $panDeltaX, '
           'panDeltaY: $panDeltaY, '
           'scale: $scale, '
           'rotation: $rotation'


Suggested change

'rotation: $rotation'

'rotation: $rotation, '

hellohuanlin

This is getting very close. just a few comments.

hellohuanlin · 2023-02-11T00:51:52Z

lib/ui/window/pointer_data.h

+  };
+
+  // Must match the PreferredStylusAuxiliaryAction enum in pointer.dart.
+


extra space

hellohuanlin · 2023-02-11T00:54:03Z

shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java

    int SCROLL_INERTIA_CANCEL = 2;
-    int SCALE = 3;
+    int STYLUS_AUXILIARY_ACTION = 3;
+    int SCALE = 4;


you may wanna keep scale as 3 and stylus action 4?

hellohuanlin · 2023-02-11T00:57:18Z

shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm

+  OCMVerify([viewControllerMock createAuxillaryStylusActionData]);
+
+  // Check the return value of the helper function
+  flutter::PointerData pointer_data = [vc createAuxillaryStylusActionData];


you may wanna create a separate test function for this helper function.

also may wanna verify all cases (rather than just the color pallet)

hellohuanlin · 2023-02-11T00:59:57Z

lib/ui/platform_dispatcher.dart

        panDeltaY: packet.getFloat64(kStride * offset++, _kFakeHostEndian),
        scale: packet.getFloat64(kStride * offset++, _kFakeHostEndian),
        rotation: packet.getFloat64(kStride * offset++, _kFakeHostEndian),
+        preferredStylusAuxiliaryAction: PointerPreferredStylusAuxiliaryAction.values[packet.getInt64(kStride * offset++, _kFakeHostEndian)],


just double check - did framework team already agree with using this naming?

its already in the design doc, and they didnt object - if they change their mind, I think it wouldnt be a big deal to change the naming.

jmagman

LGTM, thanks for spending so much time on this @LouiseHsu!

hellohuanlin

Nice! Great work!

hellohuanlin · 2023-02-13T19:56:22Z

shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm

+  [mockPencilInteraction stopMocking];
+}
+
+- (void)testPencilHelperFunction API_AVAILABLE(ios(13.4)) {


nit: testCreateAuxillaryStylusActionData

…ter/engine#39267)

This reverts commit 99a81a8.

…" (#39607) This reverts commit 99a81a8.

…ter/engine#39267)

…120656) * 8cd648d1d Roll Dart SDK from f80c5db8736a to ea59504416a8 (1 revision) (flutter/engine#39594) * 9ac09ced1 [Impeller] Fix unsafe access for clip stencil coverage (flutter/engine#39595) * 99a81a81f Add support for double tap action from Apple Pencil 2 (flutter/engine#39267) * 89d41d13e Add unique device id for trackpad on web (flutter/engine#39260) * f7dfb2b63 remove use of SkCanvas and DLCanvasRecorder from ui.Canvas native code (flutter/engine#39599) * c2e165e36 Fix multi-function compute (flutter/engine#39603) * c4f51bc78 Revert "Add support for double tap action from Apple Pencil 2 (#39267)" (flutter/engine#39607)

…#39267)" (#39607)" This reverts commit c4f51bc.

…#39267)" (#39607)" (#39637) This reverts commit c4f51bc.

* working commit * some clean up * white space fixes * whitespace * remove unused import * Addressing PR comment, fix tests, update touch packet on Andriod * formatting n whitespace again * add new field to web ui pointer.dart * update test * whitespace * fix test * PR comments * fix test * whitespace * fix test by factoring out logic into helper function * whitespace * fix malformed string * pr comments * fix type issue * sigh whitespace * revert test changes :) * pr comments + separate out tests * extra space * change test name

…r#39267)" (flutter#39607) This reverts commit 99a81a8.

…Pencil 2 (#39267)" (#39607)" (#39637)" This reverts commit b310be5.

LouiseHsu added 6 commits January 26, 2023 12:15

working commit

a945890

Merge branch 'master' into louisehsu/pencil-double-tap

04b8708

some clean up

6b7061a

white space fixes

3818c77

whitespace

1b6c8f5

remove unused import

9c31bd1

LouiseHsu requested review from hellohuanlin and jmagman January 30, 2023 22:50

flutter-dashboard bot added embedder Related to the embedder API platform-ios labels Jan 30, 2023

hellohuanlin reviewed Jan 30, 2023

View reviewed changes

jmagman reviewed Jan 30, 2023

View reviewed changes

LouiseHsu added 7 commits February 2, 2023 16:46

Addressing PR comment, fix tests, update touch packet on Andriod

c2450d4

formatting n whitespace again

0317a34

add new field to web ui pointer.dart

61296be

update test

2b5a6b9

whitespace

c18f4e9

fix test

9f780ce

Merge branch 'master' into louisehsu/pencil-double-tap

25f6607

jmagman reviewed Feb 6, 2023

View reviewed changes

LouiseHsu added 3 commits February 6, 2023 16:33

PR comments

2ec9688

fix test

a50f554

whitespace

a27ba22

jmagman reviewed Feb 7, 2023

View reviewed changes

camsim99 reviewed Feb 8, 2023

View reviewed changes

LouiseHsu added 3 commits February 9, 2023 13:54

fix test by factoring out logic into helper function

1cdf0ec

whitespace

b348378

fix malformed string

4e14bbf

jmagman reviewed Feb 9, 2023

View reviewed changes

LouiseHsu requested a review from jmagman February 11, 2023 00:47

hellohuanlin reviewed Feb 11, 2023

View reviewed changes

jmagman approved these changes Feb 11, 2023

View reviewed changes

LouiseHsu added 2 commits February 13, 2023 11:40

pr comments + separate out tests

1393fae

extra space

9527282

LouiseHsu requested a review from hellohuanlin February 13, 2023 19:42

hellohuanlin approved these changes Feb 13, 2023

View reviewed changes

change test name

b09a991

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2023

auto-submit bot merged commit 99a81a8 into flutter:main Feb 13, 2023

engine-flutter-autoroll mentioned this pull request Feb 13, 2023

Roll Flutter Engine from 31a4648cbe99 to 99a81a81f7d4 (3 revisions) flutter/flutter#120636

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2023

99a81a81f Add support for double tap action from Apple Pencil 2 (flut…

9157341

…ter/engine#39267)

engine-flutter-autoroll mentioned this pull request Feb 14, 2023

Roll Flutter Engine from 31a4648cbe99 to 89d41d13ed45 (4 revisions) flutter/flutter#120645

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2023

99a81a81f Add support for double tap action from Apple Pencil 2 (flut…

0586653

…ter/engine#39267)

engine-flutter-autoroll mentioned this pull request Feb 14, 2023

Roll Flutter Engine from 31a4648cbe99 to f7dfb2b63a91 (5 revisions) flutter/flutter#120646

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2023

99a81a81f Add support for double tap action from Apple Pencil 2 (flut…

2de5cb3

…ter/engine#39267)

engine-flutter-autoroll mentioned this pull request Feb 14, 2023

Roll Flutter Engine from 31a4648cbe99 to c2e165e36c51 (6 revisions) flutter/flutter#120651

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2023

99a81a81f Add support for double tap action from Apple Pencil 2 (flut…

983ba04

…ter/engine#39267)

jonahwilliams pushed a commit that referenced this pull request Feb 14, 2023

Revert "Add support for double tap action from Apple Pencil 2 (#39267)"

ba661c2

This reverts commit 99a81a8.

jonahwilliams mentioned this pull request Feb 14, 2023

Revert "Add support for double tap action from Apple Pencil 2" #39607

Merged

auto-submit bot pushed a commit that referenced this pull request Feb 14, 2023

Revert "Add support for double tap action from Apple Pencil 2 (#39267)…

c4f51bc

…" (#39607) This reverts commit 99a81a8.

engine-flutter-autoroll mentioned this pull request Feb 14, 2023

Roll Flutter Engine from 31a4648cbe99 to c4f51bc78644 (7 revisions) flutter/flutter#120656

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2023

99a81a81f Add support for double tap action from Apple Pencil 2 (flut…

67d0ae5

…ter/engine#39267)

LouiseHsu added a commit that referenced this pull request Feb 14, 2023

Revert "Revert "Add support for double tap action from Apple Pencil 2 (…

7101e97

…#39267)" (#39607)" This reverts commit c4f51bc.

LouiseHsu mentioned this pull request Feb 14, 2023

Add support for double tap action from Apple Pencil 2 #39637

Merged

auto-submit bot pushed a commit that referenced this pull request Feb 15, 2023

Revert "Revert "Add support for double tap action from Apple Pencil 2 (…

b310be5

…#39267)" (#39607)" (#39637) This reverts commit c4f51bc.

0xZOne pushed a commit to 0xZOne/engine that referenced this pull request Feb 20, 2023

Revert "Add support for double tap action from Apple Pencil 2 (flutte…

d283431

…r#39267)" (flutter#39607) This reverts commit 99a81a8.

LouiseHsu added a commit that referenced this pull request Apr 12, 2023

Revert "Revert "Revert "Add support for double tap action from Apple …

9faa559

…Pencil 2 (#39267)" (#39607)" (#39637)" This reverts commit b310be5.

	enum PointerPreferredAction {
	enum PointerPreferredStylusAction {

		'rotation: $rotation'
		'preferredStylusAuxiliaryAction: $preferredStylusAuxiliaryAction, '

		};

		// Must match the PreferredStylusAuxiliaryAction enum in pointer.dart.

Add support for double tap action from Apple Pencil 2 #39267

Add support for double tap action from Apple Pencil 2 #39267

Uh oh!

Conversation

LouiseHsu commented Jan 30, 2023

Pre-launch Checklist

Uh oh!

hellohuanlin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

hellohuanlin Feb 8, 2023 •

edited

Loading