Clang-tidy: made verbose print out commands and fixed quoting problem for warnings as errors

[gaaclarke]

Fixes quoting error, the extra quotes were messing up ProcessRunner who already escapes the flags.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
• I listed at least one issue that this PR fixes in the description above.
• I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
  writing and running engine tests.
• I updated/added relevant documentation (doc comments with ///).
• I signed the CLA.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[gaaclarke]

I'm going to have to append a few fixes too that have slipped in.

[auto-submit]

auto label is removed for flutter/engine, pr: 37015, due to - The status or check suite Mac Host clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

[auto-submit]

auto label is removed for flutter/engine, pr: 37015, due to - The status or check suite Mac Host clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

[gaaclarke]

I'm going to temporarily turn on printing the diff to help get this landed.

[auto-submit]

auto label is removed for flutter/engine, pr: 37015, due to - The status or check suite Windows Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

• The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

[auto-submit]

auto label is removed for flutter/engine, pr: 37015, due to - The status or check suite Mac Host clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

[gaaclarke]

So, the fix for these lints is failable. I've seen it locally get reported but not fixed.

[gaaclarke]

This one should go through if there are no other flakes. @zanderso heads up in case you want to browse the fixes I had to add. I found out too late that running the linter locally was giving me different results than the CI which was messing everything up.