Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit a276313

Browse files
gaaclarkegaaclarke
committed
manually added nolint
1 parent 4fbd53e commit a276313

File tree

8 files changed

+52
-42
lines changed

8 files changed

+52
-42
lines changed

‎display_list/display_list_builder.cc‎

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -863,7 +863,7 @@ void DisplayListBuilder::drawPoints(SkCanvas::PointMode mode,
863863
}
864864
void DisplayListBuilder::drawSkVertices(const sk_sp<SkVertices> vertices,
865865
SkBlendMode mode) {
866-
Push<DrawSkVerticesOp>(0, 1, std::move(vertices), mode);
866+
Push<DrawSkVerticesOp>(0, 1, vertices, mode);
867867
// DrawVertices applies its colors to the paint so we have no way
868868
// of controlling opacity using the current paint attributes.
869869
// Although, examination of the |mode| might find some predictable
@@ -892,8 +892,8 @@ void DisplayListBuilder::drawImage(const sk_sp<DlImage> image,
892892
DlImageSampling sampling,
893893
bool render_with_attributes) {
894894
render_with_attributes
895-
? Push<DrawImageWithAttrOp>(0, 1, std::move(image), point, sampling)
896-
: Push<DrawImageOp>(0, 1, std::move(image), point, sampling);
895+
? Push<DrawImageWithAttrOp>(0, 1, image, point, sampling)
896+
: Push<DrawImageOp>(0, 1, image, point, sampling);
897897
CheckLayerOpacityCompatibility(render_with_attributes);
898898
}
899899
void DisplayListBuilder::drawImage(const sk_sp<DlImage>& image,
@@ -914,8 +914,8 @@ void DisplayListBuilder::drawImageRect(const sk_sp<DlImage> image,
914914
DlImageSampling sampling,
915915
bool render_with_attributes,
916916
SkCanvas::SrcRectConstraint constraint) {
917-
Push<DrawImageRectOp>(0, 1, std::move(image), src, dst, sampling,
918-
render_with_attributes, constraint);
917+
Push<DrawImageRectOp>(0, 1, image, src, dst, sampling, render_with_attributes,
918+
constraint);
919919
CheckLayerOpacityCompatibility(render_with_attributes);
920920
}
921921
void DisplayListBuilder::drawImageRect(const sk_sp<DlImage>& image,
@@ -938,9 +938,8 @@ void DisplayListBuilder::drawImageNine(const sk_sp<DlImage> image,
938938
DlFilterMode filter,
939939
bool render_with_attributes) {
940940
render_with_attributes
941-
? Push<DrawImageNineWithAttrOp>(0, 1, std::move(image), center, dst,
942-
filter)
943-
: Push<DrawImageNineOp>(0, 1, std::move(image), center, dst, filter);
941+
? Push<DrawImageNineWithAttrOp>(0, 1, image, center, dst, filter)
942+
: Push<DrawImageNineOp>(0, 1, image, center, dst, filter);
944943
CheckLayerOpacityCompatibility(render_with_attributes);
945944
}
946945
void DisplayListBuilder::drawImageNine(const sk_sp<DlImage>& image,
@@ -971,9 +970,9 @@ void DisplayListBuilder::drawImageLattice(const sk_sp<DlImage> image,
971970
(x_div_count + y_div_count) * sizeof(int) +
972971
cell_count * (sizeof(SkColor) + sizeof(SkCanvas::Lattice::RectType));
973972
SkIRect src = lattice.fBounds ? *lattice.fBounds : image->bounds();
974-
void* pod = this->Push<DrawImageLatticeOp>(
975-
bytes, 1, std::move(image), x_div_count, y_div_count, cell_count, src,
976-
dst, filter, render_with_attributes);
973+
void* pod = this->Push<DrawImageLatticeOp>(bytes, 1, image, x_div_count,
974+
y_div_count, cell_count, src, dst,
975+
filter, render_with_attributes);
977976
CopyV(pod, lattice.fXDivs, x_div_count, lattice.fYDivs, y_div_count,
978977
lattice.fColors, cell_count, lattice.fRectTypes, cell_count);
979978
CheckLayerOpacityCompatibility(render_with_attributes);
@@ -992,22 +991,22 @@ void DisplayListBuilder::drawAtlas(const sk_sp<DlImage> atlas,
992991
if (colors != nullptr) {
993992
bytes += count * sizeof(DlColor);
994993
if (cull_rect != nullptr) {
995-
data_ptr = Push<DrawAtlasCulledOp>(bytes, 1, std::move(atlas), count,
996-
mode, sampling, true, *cull_rect,
997-
render_with_attributes);
994+
data_ptr =
995+
Push<DrawAtlasCulledOp>(bytes, 1, atlas, count, mode, sampling, true,
996+
*cull_rect, render_with_attributes);
998997
} else {
999-
data_ptr = Push<DrawAtlasOp>(bytes, 1, std::move(atlas), count, mode,
1000-
sampling, true, render_with_attributes);
998+
data_ptr = Push<DrawAtlasOp>(bytes, 1, atlas, count, mode, sampling, true,
999+
render_with_attributes);
10011000
}
10021001
CopyV(data_ptr, xform, count, tex, count, colors, count);
10031002
} else {
10041003
if (cull_rect != nullptr) {
1005-
data_ptr = Push<DrawAtlasCulledOp>(bytes, 1, std::move(atlas), count,
1006-
mode, sampling, false, *cull_rect,
1007-
render_with_attributes);
1004+
data_ptr =
1005+
Push<DrawAtlasCulledOp>(bytes, 1, atlas, count, mode, sampling, false,
1006+
*cull_rect, render_with_attributes);
10081007
} else {
1009-
data_ptr = Push<DrawAtlasOp>(bytes, 1, std::move(atlas), count, mode,
1010-
sampling, false, render_with_attributes);
1008+
data_ptr = Push<DrawAtlasOp>(bytes, 1, atlas, count, mode, sampling,
1009+
false, render_with_attributes);
10111010
}
10121011
CopyV(data_ptr, xform, count, tex, count);
10131012
}
@@ -1069,7 +1068,7 @@ void DisplayListBuilder::drawDisplayList(
10691068
void DisplayListBuilder::drawTextBlob(const sk_sp<SkTextBlob> blob,
10701069
SkScalar x,
10711070
SkScalar y) {
1072-
Push<DrawTextBlobOp>(0, 1, std::move(blob), x, y);
1071+
Push<DrawTextBlobOp>(0, 1, blob, x, y);
10731072
CheckLayerOpacityCompatibility();
10741073
}
10751074
void DisplayListBuilder::drawShadow(const SkPath& path,

‎flow/compositor_context.cc‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@ std::unique_ptr<CompositorContext::ScopedFrame> CompositorContext::AcquireFrame(
8181
const SkMatrix& root_surface_transformation,
8282
bool instrumentation_enabled,
8383
bool surface_supports_readback,
84-
fml::RefPtr<fml::RasterThreadMerger> raster_thread_merger,
84+
fml::RefPtr<fml::RasterThreadMerger>
85+
raster_thread_merger, // NOLINT(performance-unnecessary-value-param)
8586
DisplayListBuilder* display_list_builder) {
8687
return std::make_unique<ScopedFrame>(
8788
*this, gr_context, canvas, view_embedder, root_surface_transformation,

‎flow/diff_context.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ void DiffContext::AddReadbackRegion(const SkIRect& rect) {
202202
readback.position = rects_->size();
203203
// Push empty rect as a placeholder for position in current subtree
204204
rects_->push_back(SkRect::MakeEmpty());
205-
readbacks_.push_back(std::move(readback));
205+
readbacks_.push_back(readback);
206206
}
207207

208208
PaintRegion DiffContext::CurrentSubtreeRegion() const {

‎impeller/entity/contents/text_contents.cc‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,15 @@ std::optional<Rect> TextContents::GetCoverage(const Entity& entity) const {
5959
}
6060

6161
template <class TPipeline>
62-
static bool CommonRender(const ContentContext& renderer,
63-
const Entity& entity,
64-
RenderPass& pass,
65-
const Color& color,
66-
const TextFrame& frame,
67-
std::shared_ptr<GlyphAtlas> atlas,
68-
Command& cmd) {
62+
static bool CommonRender(
63+
const ContentContext& renderer,
64+
const Entity& entity,
65+
RenderPass& pass,
66+
const Color& color,
67+
const TextFrame& frame,
68+
std::shared_ptr<GlyphAtlas>
69+
atlas, // NOLINT(performance-unnecessary-value-param)
70+
Command& cmd) {
6971
using VS = typename TPipeline::VertexShader;
7072
using FS = typename TPipeline::FragmentShader;
7173

‎impeller/renderer/shader_library.cc‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,13 @@ ShaderLibrary::ShaderLibrary() = default;
1010

1111
ShaderLibrary::~ShaderLibrary() = default;
1212

13-
void ShaderLibrary::RegisterFunction(std::string name,
14-
ShaderStage stage,
15-
std::shared_ptr<fml::Mapping> code,
16-
RegistrationCallback callback) {
13+
void ShaderLibrary::RegisterFunction(
14+
std::string name, // NOLINT(performance-unnecessary-value-param)
15+
ShaderStage stage,
16+
std::shared_ptr<fml::Mapping>
17+
code, // NOLINT(performance-unnecessary-value-param)
18+
RegistrationCallback
19+
callback) { // NOLINT(performance-unnecessary-value-param)
1720
if (callback) {
1821
callback(false);
1922
}

‎runtime/runtime_controller.cc‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,8 @@ void RuntimeController::LoadDartDeferredLibrary(
455455

456456
void RuntimeController::LoadDartDeferredLibraryError(
457457
intptr_t loading_unit_id,
458-
const std::string error_message,
458+
const std::string
459+
error_message, // NOLINT(performance-unnecessary-value-param)
459460
bool transient) {
460461
root_isolate_.lock()->LoadLoadingUnitError(loading_unit_id, error_message,
461462
transient);

‎shell/common/platform_view.cc‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,10 @@ fml::WeakPtr<PlatformView> PlatformView::GetWeakPtr() const {
107107
return weak_factory_.GetWeakPtr();
108108
}
109109

110-
void PlatformView::UpdateSemantics(SemanticsNodeUpdates update,
111-
CustomAccessibilityActionUpdates actions) {}
110+
void PlatformView::UpdateSemantics(
111+
SemanticsNodeUpdates update, // NOLINT(performance-unnecessary-value-param)
112+
CustomAccessibilityActionUpdates actions) {
113+
} // NOLINT(performance-unnecessary-value-param)
112114

113115
void PlatformView::HandlePlatformMessage(
114116
std::unique_ptr<PlatformMessage> message) {
@@ -169,9 +171,11 @@ void PlatformView::LoadDartDeferredLibrary(
169171
std::unique_ptr<const fml::Mapping> snapshot_data,
170172
std::unique_ptr<const fml::Mapping> snapshot_instructions) {}
171173

172-
void PlatformView::LoadDartDeferredLibraryError(intptr_t loading_unit_id,
173-
const std::string error_message,
174-
bool transient) {}
174+
void PlatformView::LoadDartDeferredLibraryError(
175+
intptr_t loading_unit_id,
176+
const std::string
177+
error_message, // NOLINT(performance-unnecessary-value-param)
178+
bool transient) {}
175179

176180
void PlatformView::UpdateAssetResolverByType(
177181
std::unique_ptr<AssetResolver> updated_asset_resolver,

‎testing/display_list_testing.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ std::ostream& DisplayListStreamDispatcher::startl() {
302302
}
303303

304304
template <class T>
305-
std::ostream& DisplayListStreamDispatcher::out_array(std::string name,
305+
std::ostream& DisplayListStreamDispatcher::out_array(std::string name, // NOLINT(performance-unnecessary-value-param)
306306
int count,
307307
const T array[]) {
308308
if (array == nullptr || count < 0) {

0 commit comments

Comments
 (0)