This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Animator stopped notifying delegate to render when pipeline is not empty #31727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColdPaleLight
requested review from
chinmaygarde,
dnfield and
iskakaushik
and removed request for
chinmaygarde,
dnfield and
iskakaushik
ColdPaleLight
changed the title
dnfield
reviewed
Mar 1, 2022
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
A few nits. @iskakaushik or @chinmaygarde may be interested in taking a look.
shell/common/animator.cc
Outdated
| // It has been successfully pushed to the pipeline but not as the first | ||
| // item. Eventually the 'Rasterizer' will consume it, so we don't need to | ||
| // notify the delegate. | ||
| FML_DLOG(INFO) << "Not the first item in the pipeline, ignore it"; |
Contributor
There was a problem hiding this comment.
nit: this log is likely to be noisy. I know it's only in local unopt builds, but I'm not sure what action I'd ever want to take if I was debugging a local engine build. We should drop it.
shell/common/pipeline.h
Outdated
| // Ensure the queue mutex is not held as that would be a pessimization. | ||
| available_.Signal(); | ||
| return true; | ||
| return {/*success=*/true, /*is_first_item=*/is_first_item}; |
Contributor
There was a problem hiding this comment.
nit:
return {.success=true, .is_first_item=is_first_item};
ColdPaleLight
changed the title
chinmaygarde
approved these changes
Mar 10, 2022
dnfield
approved these changes
Mar 10, 2022
dnfield
added
the
waiting for tree to go green
Merged
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 14, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 14, 2022
* ba6f4f5 Roll Skia from c88fff00c8fd to 02ea811ce869 (4 revisions) (flutter/engine#31955) * 1a8033c Revert "Add a message when a key response takes too long. (#31945)" (flutter/engine#31962) * ebcd86f68 Make sure the secondary vsync callback is called after the vsync callback (flutter/engine#31513) * 2c94cc5 Generate a11y events for widgets that use kFlutterSemanticsFlagIsToggled (flutter/engine#31582) * e21a58d [macOS, Keyboard] Refactor: Clean up keyboard initialization, connection, and unit test framework (flutter/engine#31940) * 27e62d0 Set a11y roles for checks, toggles and sliders. (flutter/engine#31600) * 5e760f6 Fix signals adding/removing a11y nodes in Linux. (flutter/engine#31601) * 749dc3a Changed the default a11y node role from ATK_ROLE_FRAME to ATK_ROLE_PANEL (flutter/engine#31602) * da7bae6 Animator stopped notifying delegate to render when pipeline is not empty (flutter/engine#31727) * 77dd8af Roll Fuchsia Mac SDK from y2eJ9z95V... to j7jyFiU9e... (flutter/engine#31960) * 3f803b2 Roll Skia from 02ea811ce869 to b141e485d248 (5 revisions) (flutter/engine#31961) * 187a277 Roll Fuchsia Linux SDK from -9uFZIRSL... to k8Vq-HEG-... (flutter/engine#31971) * 43975b2 Roll Skia from b141e485d248 to 1df655a42746 (13 revisions) (flutter/engine#31975) * ab12f81 Roll Fuchsia Mac SDK from j7jyFiU9e... to g8opaxAq7... (flutter/engine#31978) * 93b792f Roll Skia from 1df655a42746 to 38b9591b5a04 (1 revision) (flutter/engine#31979) * d6964c0 Update jazzy to 0.14.1. (flutter/engine#31970) * 31def4e Re-enable dart runner AOT builds (flutter/engine#31844) * 887a193 Roll Fuchsia Linux SDK from k8Vq-HEG-... to mDjjSq8Im... (flutter/engine#31980) * afd9ce1 Roll Fuchsia Mac SDK from g8opaxAq7... to f8IibBq3a... (flutter/engine#31983) * f7d8314 Roll Fuchsia Linux SDK from mDjjSq8Im... to BEc_F0_Fp... (flutter/engine#31986) * 503c02c Roll Fuchsia Mac SDK from f8IibBq3a... to oyZzinh6U... (flutter/engine#31987) * caa3f3d Roll Fuchsia Linux SDK from BEc_F0_Fp... to obtypxiCA... (flutter/engine#31988) * 4643016 Roll Dart SDK from 4fbe27c0f148 to 3e76a897013f (5 revisions) (flutter/engine#31989) * 06d3d06 Roll Dart SDK from 3e76a897013f to 55b9ec4e382a (5 revisions) (flutter/engine#31991) * cdf862b Roll Skia from 38b9591b5a04 to 6d19271fb148 (2 revisions) (flutter/engine#31992) * bbebccd Roll Fuchsia Mac SDK from oyZzinh6U... to rmQ9yYUaF... (flutter/engine#31993) * 56187fa Fix timestamp of touch events should use system startup time (flutter/engine#30422) * 1dab008 Roll Fuchsia Linux SDK from obtypxiCA... to xYtoLAOvY... (flutter/engine#31995) * fccde49 Add systemFontFamily to flutter/settings channel (flutter/engine#22981) * 2a8c4f4 Roll Fuchsia Mac SDK from rmQ9yYUaF... to 84kG1vmHe... (flutter/engine#31996) * e6cf464 Roll Skia from 6d19271fb148 to 7a61e5d65399 (1 revision) (flutter/engine#31997) * 1cc349e Roll Fuchsia Linux SDK from xYtoLAOvY... to P8RdLi_Y_... (flutter/engine#31999) * 25acd77 Roll Skia from 7a61e5d65399 to 02527b7182ea (1 revision) (flutter/engine#32000)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix flutter/flutter#98959
Pre-launch Checklist
writing and running engine tests.
///).