Set a11y roles for checks, toggles and sliders. (#31600)

robert-ancell · web-flow · commit 27e62d07415d · 2022-03-10T22:40:05.000-08:00
diff --git a/shell/platform/linux/fl_accessible_node.cc b/shell/platform/linux/fl_accessible_node.cc
@@ -176,6 +176,13 @@ static AtkRole fl_accessible_node_get_role(AtkObject* accessible) {
   if ((self->flags & kFlutterSemanticsFlagIsButton) != 0) {
     return ATK_ROLE_PUSH_BUTTON;
   }
+  if ((self->flags & (kFlutterSemanticsFlagHasCheckedState |
+                      kFlutterSemanticsFlagHasToggledState)) != 0) {
+    return ATK_ROLE_CHECK_BOX;
+  }
+  if ((self->flags & kFlutterSemanticsFlagIsSlider) != 0) {
+    return ATK_ROLE_SLIDER;
+  }
   if ((self->flags & kFlutterSemanticsFlagIsTextField) != 0) {
     return ATK_ROLE_TEXT;
   }

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,13 @@ static AtkRole fl_accessible_node_get_role(AtkObject* accessible) {`
`176`	`176`	`if ((self->flags & kFlutterSemanticsFlagIsButton) != 0) {`
`177`	`177`	`return ATK_ROLE_PUSH_BUTTON;`
`178`	`178`	`}`
	`179`	`+ if ((self->flags & (kFlutterSemanticsFlagHasCheckedState \|`
	`180`	`+ kFlutterSemanticsFlagHasToggledState)) != 0) {`
	`181`	`+ return ATK_ROLE_CHECK_BOX;`
	`182`	`+ }`
	`183`	`+ if ((self->flags & kFlutterSemanticsFlagIsSlider) != 0) {`
	`184`	`+ return ATK_ROLE_SLIDER;`
	`185`	`+ }`
`179`	`186`	`if ((self->flags & kFlutterSemanticsFlagIsTextField) != 0) {`
`180`	`187`	`return ATK_ROLE_TEXT;`
`181`	`188`	`}`