Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@iskakaushik
Copy link
Contributor

Reverts #29591

See internal b/218976529

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde
Copy link
Member

There is no update on the internal bug. But we do believe there is a real issue with dirty region management that is being patched in #31359. So depending on how quickly that patch is reviewed and landed, this PR may be unnecessary as we can fix forward.

@chinmaygarde
Copy link
Member

Per the updates in the linked issue, this is not necessary.

@zanderso zanderso deleted the revert-29591-partial_update_android branch March 8, 2022 03:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants