Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@knopp
Copy link
Member

@knopp knopp commented Feb 9, 2022

Fixes: flutter/flutter#97482

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@knopp knopp force-pushed the diff_clip_alignment branch from e2e2be5 to 58fbf1a Compare February 9, 2022 21:26
@knopp knopp removed the needs tests label Feb 10, 2022
@knopp knopp changed the title WIP: Specify clip alignment for partial repaint Specify clip alignment for partial repaint Feb 10, 2022
@knopp knopp requested a review from iskakaushik February 10, 2022 13:36
@chinmaygarde
Copy link
Member

cc @iskakaushik Do you have the cycles to review this please?

@knopp
Copy link
Member Author

knopp commented Feb 17, 2022

The original Android PR was reverted because of internal performance regressions.

@chinmaygarde
Copy link
Member

@knopp The revert did not land so this ought to be good to go.

Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skia-gold
Copy link

Gold has detected about 10 new digest(s) on patchset 3.
View them at https://flutter-engine-gold.skia.org/cl/github/31359

@chinmaygarde
Copy link
Member

Following up on why the presubs have not been kicked off on this patch.

@zanderso
Copy link
Member

From PR review triage: What is the status of this PR?

@knopp knopp force-pushed the diff_clip_alignment branch from 581fd54 to 90698f9 Compare March 31, 2022 20:05
@zanderso zanderso requested a review from iskakaushik March 31, 2022 20:05
@knopp
Copy link
Member Author

knopp commented Mar 31, 2022

This can be merged as soon as the tests pass.

@knopp knopp merged commit b026706 into flutter:main Mar 31, 2022
@knopp knopp deleted the diff_clip_alignment branch March 31, 2022 21:53
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DraggableScrollableSheet leaves traces when scrolling

5 participants