Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Enable repeat for desktop embedder tests #28253

Merged
merged 4 commits into from
Aug 23, 2021
Merged

Enable repeat for desktop embedder tests #28253

merged 4 commits into from
Aug 23, 2021

Conversation

@knopp
Copy link
Member

@knopp knopp commented Aug 22, 2021 •
edited
Loading

Originally disabled in #22323.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label Aug 22, 2021
@google-cla google-cla bot added the cla: yes label Aug 22, 2021
@knopp knopp changed the title Enable repeat for desktop tests Enable repeat for windows embedder tests Aug 22, 2021
@knopp knopp force-pushed the enable_test_repeat branch from f70d86f to db5dabb Compare August 22, 2021 18:55
@knopp knopp changed the title Enable repeat for windows embedder tests Enable repeat for desktop embedder tests Aug 22, 2021
@knopp knopp requested a review from stuartmorgan-g August 22, 2021 19:29
stuartmorgan-g
stuartmorgan-g approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@knopp knopp added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 23, 2021
@fluttergithubbot fluttergithubbot merged commit af1dd97 into flutter:master Aug 23, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2021
@engine-flutter-autoroll
af1dd97 Enable repeat for desktop embedder tests (flutter/engine#28253)
7326124
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes embedder Related to the embedder API waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knopp @stuartmorgan-g @fluttergithubbot