Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

Description

Sends the flutter/settings update message to the engine after starting
it. For now values other than 24-hour time preference are hard-coded,
but dark mode support can be added later.

Related Issues

Fixes flutter/flutter#65590

Tests

I added the following tests: A new test of engine initialization, including validating that this new message is sent.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change.

Sends the flutter/settings update message to the engine after starting
it. For now values other than 24-hour time preference are hard-coded,
but dark mode support can be added later.

Fixes flutter/flutter#65590
@stuartmorgan-g
Copy link
Contributor Author

@cbracken Ping

@stuartmorgan-g
Copy link
Contributor Author

At least for now I've turned off gtest_repeat (added in #12275) for the desktop embedding unit tests, because the lambda approach we're using is incompatible with multiple runs (I just hadn't noticed yet since we are just starting these tests). If we want to be able to support gtest_repeat, we'll need to completely revisit how we handle proctable replacement.

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chinmaygarde
Copy link
Member

I've filed a presubmit flake report and rerun the presubmit.

@stuartmorgan-g stuartmorgan-g merged commit 9f207a3 into flutter:master Nov 23, 2020
@stuartmorgan-g stuartmorgan-g deleted the windows-settings-channel branch November 23, 2020 23:58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 24, 2020
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
Sends the flutter/settings update message to the engine after starting
it. For now values other than 24-hour time preference are hard-coded,
but dark mode support can be added later.

Fixes flutter/flutter#65590
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement flutter/settings channel in Windows embedding

3 participants