This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Support iOS universal links route deep linking #27874
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,84 +14,129 @@ | |
| FLUTTER_ASSERT_ARC | ||
|
|
||
| @interface FlutterAppDelegateTest : XCTestCase | ||
| @property(strong) FlutterAppDelegate* appDelegate; | ||
|
|
||
| @property(strong) id mockMainBundle; | ||
| @property(strong) id mockNavigationChannel; | ||
|
|
||
| // Retain callback until the tests are done. | ||
| // https://github.com/flutter/flutter/issues/74267 | ||
| @property(strong) id mockEngineFirstFrameCallback; | ||
|
There was a problem hiding this comment. I only just landed #27854 but this is probably a better name than |
||
| @end | ||
|
|
||
| @implementation FlutterAppDelegateTest | ||
|
|
||
| - (void)setUp { | ||
| [super setUp]; | ||
|
|
||
| id mockMainBundle = OCMClassMock([NSBundle class]); | ||
| OCMStub([mockMainBundle mainBundle]).andReturn(mockMainBundle); | ||
| self.mockMainBundle = mockMainBundle; | ||
|
|
||
| FlutterAppDelegate* appDelegate = [[FlutterAppDelegate alloc] init]; | ||
| self.appDelegate = appDelegate; | ||
|
|
||
| FlutterViewController* viewController = OCMClassMock([FlutterViewController class]); | ||
| FlutterMethodChannel* navigationChannel = OCMClassMock([FlutterMethodChannel class]); | ||
| self.mockNavigationChannel = navigationChannel; | ||
|
|
||
| FlutterEngine* engine = OCMClassMock([FlutterEngine class]); | ||
| OCMStub([engine navigationChannel]).andReturn(navigationChannel); | ||
| OCMStub([viewController engine]).andReturn(engine); | ||
|
|
||
| id mockEngineFirstFrameCallback = [OCMArg invokeBlockWithArgs:@NO, nil]; | ||
| self.mockEngineFirstFrameCallback = mockEngineFirstFrameCallback; | ||
| OCMStub([engine waitForFirstFrame:3.0 callback:mockEngineFirstFrameCallback]); | ||
| appDelegate.rootFlutterViewControllerGetter = ^{ | ||
| return viewController; | ||
| }; | ||
| } | ||
|
|
||
| - (void)tearDown { | ||
| // Explicitly stop mocking the NSBundle class property. | ||
| [self.mockMainBundle stopMocking]; | ||
| [super tearDown]; | ||
| } | ||
|
|
||
| - (void)testLaunchUrl { | ||
| OCMStub([self.mockMainBundle objectForInfoDictionaryKey:@"FlutterDeepLinkingEnabled"]) | ||
| .andReturn(@YES); | ||
|
|
||
| BOOL result = | ||
| [self.appDelegate application:[UIApplication sharedApplication] | ||
| openURL:[NSURL URLWithString:@"http://myApp/custom/route?query=test"] | ||
| options:@{}]; | ||
| XCTAssertTrue(result); | ||
| OCMVerify([self.mockNavigationChannel invokeMethod:@"pushRoute" | ||
| arguments:@"/custom/route?query=test"]); | ||
| } | ||
|
|
||
| - (void)testLaunchUrlWithDeepLinkingNotSet { | ||
|
|
||
| OCMStub([self.mockMainBundle objectForInfoDictionaryKey:@"FlutterDeepLinkingEnabled"]) | ||
| .andReturn(nil); | ||
|
|
||
| BOOL result = | ||
| [self.appDelegate application:[UIApplication sharedApplication] | ||
| openURL:[NSURL URLWithString:@"http://myApp/custom/route?query=test"] | ||
| options:@{}]; | ||
| XCTAssertFalse(result); | ||
| OCMReject([self.mockNavigationChannel invokeMethod:OCMOCK_ANY arguments:OCMOCK_ANY]); | ||
| } | ||
|
|
||
| - (void)testLaunchUrlWithDeepLinkingDisabled { | ||
|
|
||
| OCMStub([self.mockMainBundle objectForInfoDictionaryKey:@"FlutterDeepLinkingEnabled"]) | ||
| .andReturn(@NO); | ||
|
|
||
| BOOL result = | ||
| [self.appDelegate application:[UIApplication sharedApplication] | ||
| openURL:[NSURL URLWithString:@"http://myApp/custom/route?query=test"] | ||
| options:@{}]; | ||
| XCTAssertFalse(result); | ||
| OCMReject([self.mockNavigationChannel invokeMethod:OCMOCK_ANY arguments:OCMOCK_ANY]); | ||
| } | ||
|
|
||
| - (void)testLaunchUrlWithQueryParameterAndFragment { | ||
| OCMStub([self.mockMainBundle objectForInfoDictionaryKey:@"FlutterDeepLinkingEnabled"]) | ||
| .andReturn(@YES); | ||
|
|
||
| BOOL result = [self.appDelegate | ||
| application:[UIApplication sharedApplication] | ||
| openURL:[NSURL URLWithString:@"http://myApp/custom/route?query=test#fragment"] | ||
| options:@{}]; | ||
| XCTAssertTrue(result); | ||
| OCMVerify([self.mockNavigationChannel invokeMethod:@"pushRoute" | ||
| arguments:@"/custom/route?query=test#fragment"]); | ||
| } | ||
|
|
||
| - (void)testLaunchUrlWithFragmentNoQueryParameter { | ||
| OCMStub([self.mockMainBundle objectForInfoDictionaryKey:@"FlutterDeepLinkingEnabled"]) | ||
| .andReturn(@YES); | ||
|
|
||
| BOOL result = | ||
| [self.appDelegate application:[UIApplication sharedApplication] | ||
| openURL:[NSURL URLWithString:@"http://myApp/custom/route#fragment"] | ||
| options:@{}]; | ||
| XCTAssertTrue(result); | ||
| OCMVerify([self.mockNavigationChannel invokeMethod:@"pushRoute" | ||
| arguments:@"/custom/route#fragment"]); | ||
| } | ||
|
|
||
| #pragma mark - Deep linking | ||
|
|
||
| - (void)testUniversalLinkPushRoute { | ||
|
There was a problem hiding this comment. These 2 tests are very similar, maybe it's worth considering pulling out a helper function to remove some of the boilerplate so the differences are more apparent. There was a problem hiding this comment. I pulled the boilderplate in all these tests up into |
||
| OCMStub([self.mockMainBundle objectForInfoDictionaryKey:@"FlutterDeepLinkingEnabled"]) | ||
| .andReturn(@YES); | ||
|
|
||
| NSUserActivity* userActivity = [[NSUserActivity alloc] initWithActivityType:@"com.example.test"]; | ||
| userActivity.webpageURL = [NSURL URLWithString:@"http://myApp/custom/route?query=test"]; | ||
| BOOL result = [self.appDelegate | ||
| application:[UIApplication sharedApplication] | ||
| continueUserActivity:userActivity | ||
| restorationHandler:^(NSArray<id<UIUserActivityRestoring>>* __nullable restorableObjects){ | ||
| }]; | ||
| XCTAssertTrue(result); | ||
| OCMVerify([self.mockNavigationChannel invokeMethod:@"pushRoute" | ||
| arguments:@"/custom/route?query=test"]); | ||
| } | ||
|
|
||
| @end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is now shared between two app delegate methods. Move the method-specific
_lifeCycleDelegatecheck up one level to-application:openURL:options:.